[Bug 1795610] Re: New voluptuous breaks ubuntu-image

[Łukasz Zemczak]

Sorry! I personally don't find that fix *that* ugly. Yes, the line is
long but it makes it clear what is what and why, at least for me. Sure,
this probably could be done slightly different like using a variable
instead, but to me personally all those solutions seemed ugly in some
sense.

It's annoying that because of how the default value validation has been
implemented, we can't really have one satisfying way of doing it across
different voluptuous versions. Maybe there is some other, smarter way to
have our enum be able to be 'fed' to the validation in cases of when
it's before and after value conversion, but I'd have to take a deeper
look on how voluptuous works.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-image in Ubuntu.
https://bugs.launchpad.net/bugs/1795610

Title:
  New voluptuous breaks ubuntu-image

Status in Ubuntu Image:
  Fix Committed
Status in ubuntu-image package in Ubuntu:
  Fix Released

Bug description:
  We had a sync of voluptuous 0.11.1 from debian sitting in cosmic-
  proposed, apparently stuck on ubuntu-image autopkgtests. After ubuntu-
  image got hinted in because of a failing flake8 tests (because of a
  new pycodestyle sync in cosmic, sigh), voluptuous migrated to release
  and completely broke ubuntu-image.

  The breakage is made visible already through autopkgtests (which is
  why voluptuous was blocked). I saw the same issue when our
  snapcraft.yaml for snap builds was using pip for pulling in
  voluptuous. To save time I have switched to using the deb instead back
  then. Now the incompatibilities between 0.9.x and 0.11.x are back and
  almost all parser-related tests are now failing. And they're failing
  for good reason, since basically our yaml parser stopped working.

  I am still investigating the reason for the incompatibilities, but it
  seems voluptuous stopped liking the default values of schema entries
  that are using Enumify. 0.11.0 did seem to have introduces some
  'strict default value validation' thing that is supposed to be
  backwards incompatible and I assume this is the source of the problem.
  The thing is that, in theory, the default value we provide for those
  are valid default values, but maybe there's something special in how
  the validation is done.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-image/+bug/1795610/+subscriptions