[Bug 1785093] Re: RecursionError error in call_adjusted()

[Launchpad Bug Tracker]

This bug was fixed in the package unattended-upgrades -
1.1ubuntu1.18.04.6

---------------
unattended-upgrades (1.1ubuntu1.18.04.6) bionic; urgency=medium

  * Unlock for dpkg operations with apt_pkg.pkgsystem_unlock_inner() when it is
    available. Also stop running when reacquiring the lock fails.
    Thanks to Julian Andres Klode for original partial patch (LP: #1789637)
  * Skip rebuilding python-apt in upgrade autopkgtests.
    Python-apt has a new build dependency making the rebuilding as is failing
    and the reference handling issue is worked around in unattended-upgrades
    already. (LP: #1781586)
  * Stop trying when no adjustment could be made and adjust package candidates
    only to lower versions (LP: #1785093)
  * Skip already adjusted packages from being checked for readjusting.
    This makes it clearer that the recursion ends and can also be a bit quicker.
    (LP: #1785093)

 -- Balint Reczey <rbalint at ubuntu.com>  Tue, 02 Oct 2018 19:18:02 +0200

** Changed in: unattended-upgrades (Ubuntu Bionic)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1785093

Title:
  RecursionError error in call_adjusted()

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Bionic:
  Fix Released

Bug description:
  [Impact]

   * Unattended-upgrades may crash and stop installing security updates on users' system due to entering infinite loop.
   * The fix ensures terminating the recursive calls.

  [Test Case]

   * TODO / observe the crash not being reported for fixed releases on
  errors.ubuntu.com.

  [Regression Potential]

   * Unattended-upgrades now adjusts package candidates only to lower versions than the one originally offered by apt's resolver. This is a change in behavior which aligns well with the default configuration, i.e. installing packages from -security but not from -updates, since -updates almost always have higher version numbers. This change may cause using different upgrade paths when PPAs are involved and all packages can't be upgraded to the highest versions found in allowed origins, because of Conflicts: for example.
   * Unexpected regressions can cause candidate adjustments not taking place, but please note that autopkgtest now includes applying all outstanding security updates for the release thus the new code is covered, too.

  [Original Bug report]

  The Ubuntu Error Tracker has been receiving reports about a problem regarding unattended-upgrades.  This problem was most recently seen with package version 1.1ubuntu1.18.04.5, the problem page at https://errors.ubuntu.com/problem/fa706afe2f0e04b661fe54da0a59b9fc3da50734 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrade", line 1991, in <module>
      sys.exit(main(options))
    File "/usr/bin/unattended-upgrade", line 1647, in main
      cache, options, allowed_origins, blacklisted_pkgs, whitelisted_pkgs)
    File "/usr/bin/unattended-upgrade", line 1349, in calculate_upgradable_pkgs
      whitelisted_pkgs)
    File "/usr/bin/unattended-upgrade", line 1288, in try_to_upgrade
      cache.mark_upgrade_adjusted(pkg, from_user=not pkg.is_auto_installed)
    File "/usr/bin/unattended-upgrade", line 212, in mark_upgrade_adjusted
      self.call_adjusted(apt.package.Package.mark_upgrade, pkg, **kwargs)
    File "/usr/bin/unattended-upgrade", line 206, in call_adjusted
      self.call_adjusted(function, pkg, **kwargs)
    File "/usr/bin/unattended-upgrade", line 206, in call_adjusted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1785093/+subscriptions