[Bug 1762385] Re: dell_wmi: Unknown key codes

[Dimitri John Ledkov]

Either this change will make the rfkill button work (good), or not
(current behaviour). Given the code paths, validating similar SKUs for
non-regression is a good enough confidence level that this change
doesn't regress other/unrelated machines. It's a low risk to accept this
change as is, because the worst case scenario is a no-change in
behaviour. The upside is that it may have fixed rfkill button.

Also if this change doesn't fix the rfkill buttons on these laptops, it
would imply that later releases and upstream master are also still
broken and unfixed.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1762385

Title:
  dell_wmi: Unknown key codes

Status in OEM Priority Project:
  Triaged
Status in linux package in Ubuntu:
  Fix Committed
Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Xenial:
  Fix Committed
Status in linux source package in Bionic:
  Fix Released
Status in systemd source package in Bionic:
  Fix Released
Status in linux source package in Cosmic:
  Fix Committed
Status in systemd source package in Cosmic:
  Fix Released

Bug description:
  [Impact]

   * Bogus keycode messages produced by the kernel / user annoyance
   * rfkill keyboard shortcuts not working as intended on some Dell machines

  [Test Case]

   * check that there are no spurious kernel messages about unknown keys
  in journalctl upon RFKill key presses

   * check that RFKill key presses work correctly and kill/restore RF
  capabilities

  [Regression Potential]

   * The change is scoped to particular SKUs and thus should only affect them
   * It is related to matching gsd support, which is in-place on xenial and up

  [Solution]
  Cherrypick upstream commit https://github.com/systemd/systemd/commit/cab01e9ecf1c69656785e64f5fc94cd4ed09e57f

  [Original Bug report]

  RFKill key produces these messages in kernel log:

  dell_wmi: Unknown key with type 0x0010 and code 0xe008 pressed

  This key code is a notification and should be added as KEY_IGNORE
  here:
  https://github.com/torvalds/linux/blob/master/drivers/platform/x86
  /dell-wmi.c#L263

  ProblemType: Bug
  DistroRelease: Ubuntu 18.04
  Package: linux-image-4.15.0-15-generic 4.15.0-15.16
  ProcVersionSignature: Ubuntu 4.15.0-15.16-generic 4.15.15
  Uname: Linux 4.15.0-15-generic x86_64
  ApportVersion: 2.20.9-0ubuntu4
  Architecture: amd64
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC0:  dmig       2737 F.... pulseaudio
  CurrentDesktop: ubuntu:GNOME
  Date: Mon Apr  9 18:09:03 2018
  InstallationDate: Installed on 2018-03-27 (12 days ago)
  InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Alpha amd64 (20180327)
  MachineType: Dell Inc. Inspiron 5379
  ProcFB: 0 inteldrmfb
  ProcKernelCmdLine: BOOT_IMAGE=/@/boot/vmlinuz-4.15.0-15-generic root=UUID=9745e22b-0b19-4a7d-98a0-1a4bc5b19d99 ro rootflags=subvol=@ quiet splash vt.handoff=1
  RelatedPackageVersions:
   linux-restricted-modules-4.15.0-15-generic N/A
   linux-backports-modules-4.15.0-15-generic  N/A
   linux-firmware                             1.173
  SourcePackage: linux
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 01/31/2018
  dmi.bios.vendor: Dell Inc.
  dmi.bios.version: 1.6.0
  dmi.board.name: 0C6J64
  dmi.board.vendor: Dell Inc.
  dmi.board.version: A00
  dmi.chassis.type: 10
  dmi.chassis.vendor: Dell Inc.
  dmi.modalias: dmi:bvnDellInc.:bvr1.6.0:bd01/31/2018:svnDellInc.:pnInspiron5379:pvr:rvnDellInc.:rn0C6J64:rvrA00:cvnDellInc.:ct10:cvr:
  dmi.product.family: Inspiron
  dmi.product.name: Inspiron 5379
  dmi.sys.vendor: Dell Inc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1762385/+subscriptions