[Bug 1781128] Comment bridged from LTC Bugzilla

[bugproxy]

------- Comment From carll at us.ibm.com 2018-10-31 17:07 EDT-------
Will:

I don't seem to have an old Valgrind tree around that used the svn
revision control to examine.

But according to my notes, the functional fix was committed in svn
revision 395709 on June 21, 2018.   The functional fix adds the support
for the instruction to Valgrind and the support for the instruction to
the functional test test_isa_2_06_part3.c to the test suite.  However,
the expected result file changes didn't get included in that commit.

It looks like Valgrind switched to the Git repository right after that.
I see the expected results for the test case were committed in the git
repository as:

commit 1f69ed86e994ee152a0e6e3ee7031d0105f02a7e
Author: Carl Love <carll at us.ibm.com>
Date:   Mon Jun 25 16:24:14 2018 -0500
Fix ppc32 results for test_isa_2_06_part3.c.
The ppc32 results were not updated when the xvnegsp instruction support
was added.  Add the xvnegsp 32-bit results to
ppc/test_isa_2_06_part3.stdout.exp.

So, all of the functional Valgrind and test case changes went in on the
first commit.  Hopefully that clears up your question?

Carl Love

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to valgrind in Ubuntu.
https://bugs.launchpad.net/bugs/1781128

Title:
  Valgrind utility is missing bug fixes since 3.13.0 release

Status in The Ubuntu-power-systems project:
  Fix Committed
Status in valgrind package in Ubuntu:
  Fix Released
Status in valgrind source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

   * Valgrind is unable to execute certain binaries, or executes them
  incorrectly on ppc64el platform in bionic.

  [Test Case]

   * Compile the following test cases, they should execute correctly
  normally and under valgrind; without illegal opcodes and returning the
  same output lengths for timebase.

  int main()
  {
  asm ("mtspr 3,0");
  }

  int main()
  {
  asm ("xvnegsp 33,34");
  }

  #include <stdio.h>
  #include <sys/platform/ppc.h>

  int main(int argc, char** argv)
  {
  uint64_t tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);
  sleep(15);
  tb = __ppc_get_timebase();
  printf("timebase = %lx\n", tb);

  return 0;
  }

  
  [Regression Potential] 

   * These are upstream included and tested patches, cherrypicked into
  bionic, affect power code-paths only, and tested/released in cosmic.

  [Other Info]
   
   * Original bug report.

  ---Problem Description---
  Valgrind is missing the PPC64 bug fixes and fixes for missing support since the Valgrind 3.13.0 release in June of 2017.  This is causing users trying to use Valgrind to get internal Valgrind errors.  This bugzilla is to get the latest PPC64 patches added to the Ubuntu 18.04 release.

  ---uname output---
  Linux genoa 4.4.0-130-generic #156-Ubuntu

  Machine Type = Power 9

  ---Steps to Reproduce---
   Valgrind ./user_application
  Where the user_application includes vpermr instructions

  Need to have this bugzilla mirred to the Ubuntu Launchpad so we can
  get the right people from Ubuntu to discuss how to address getting the
  needed updates into the long term release support for 18.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1781128/+subscriptions