[Bug 1823410] Re: utils.py's url_downloadable doesn't support https

[Łukasz Zemczak]

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into cosmic-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/ubuntu-release-upgrader/1:18.10.11.6 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-cosmic to verification-done-cosmic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-cosmic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Cosmic)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1823410

Title:
  utils.py's url_downloadable doesn't support https

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in update-manager package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in update-manager source package in Bionic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Committed
Status in update-manager source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]
  In the interest of improving release upgrades for users of PPAs a check was added to ubuntu-release-upgrader to see if the release to which the system is being upgraded is provided by a sources list entry and if it is not that entry is disabled. This check uses the function url_downloadable which is provided by update-manager's utils.py. Come to find out the url_downloadable check only supports ftp and http, not https. This can cause a situation where upgrades to the next release of Ubuntu fail if the system's mirror of the Ubuntu archive is using https. This is mentioned here - https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1807043/comments/10.

  While the bug manifests itself in ubuntu-release-upgrader it needs
  fixing in update-manager and will require a rebuild of ubuntu-release-
  upgrader which has a symlink to utils.py which is shipped in the dist-
  upgrader tarball.

  [Test Case]
  update-manager - only ubuntu-release-upgrader uses url_downloadable but I added a test to update-manager to ensure that https works, the test may be skipped though if the https test site is not available so keep an eye out for that.

  ubuntu-release-upgrader
  1) On a xenial or bionic system edit your sources.list file so that you are using an https mirror of the archive.
  2) try to upgrade to the next release of ubuntu using 'do-release-upgrade'

  With the version of ubuntu-release-upgrader in the archive you will
  not be allowed to upgrade because ubuntu-minimal will not be found.
  With the version in -proposed, accessed by using 'do-release-upgrade
  -p' you should be able to upgrade to the next release of Ubuntu.

  [Regression Potential]
  There isn't much chance of a regression as we are just adding https to the list of schemes that we will test with urlopen.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1823410/+subscriptions