[Bug 1822340] Re: [UIFe] motd messaging rewrite

[Julian Andres Klode]

Verified [...]ubuntu6

* Package built successfully, so motd output formatting is correct

* motd output is correct, wrt counting stuff:


(1) ESM disabled [will only happen with new ua client, so not that relevant right now]

root at tt:~# /usr/lib/update-notifier/apt-check --human-readable
Extended Security Maintenance (ESM) is not enabled.

2 updates can be installed immediately.
0 of these updates are security updates.

Enable ESM to receive 5 additional security updates.
See 'ua enable esm' or https://ubuntu.com/esm


(2) ESM enabled

root at tt:~# /usr/lib/update-notifier/apt-check --human-readable
Extended Security Maintenance (ESM) is enabled.

7 updates can be installed immediately.
5 of these updates are provided through ESM.
5 of these updates are security updates.

(3) ESM fully disabled (no sources.list entry)

root at tt:~# ubuntu-advantage disable-esm
Running apt-get update... OK
Ubuntu ESM repository disabled.
root at tt:~# /usr/lib/update-notifier/apt-check --human-readable
2 updates can be installed immediately.
0 of these updates are security updates.


** Tags removed: verification-needed verification-needed-trusty
** Tags added: verification-done verification-done-trusty

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1822340

Title:
  [UIFe] motd messaging rewrite

Status in update-notifier package in Ubuntu:
  Fix Committed
Status in update-notifier source package in Trusty:
  Fix Committed

Bug description:
  [Impact]
  Changes to the motd and update counting to count ESM security upgrades as security upgrades, and show some information about ESM upgrades.

  [Test case]
  The motd output has unit tests for the various combinations, passing counts of various upgrade types. That said, the actual counting might be wrong.

  The regression potential is higher in releases with ESM, as they'll
  get more messages and have more stuff that could go wrong.

  [Regression potential]
  Potentially wrong reporting, lost translations.

  [disco UIFe]
  https://lists.ubuntu.com/archives/ubuntu-translators/2019-April/007534.html
  ubuntu-doc held for moderation

  [SRU]
  We're only SRUing this to trusty, as xenial and bionic will have some more changes, and it would just be a waste of time to SRU the trusty one there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1822340/+subscriptions