[Bug 1824430] Re: disco dist-upgrader tarball has a broken symlink in it

[Brian Murray]

I followed the test case from the bug description and no longer received
the message regarding livepatch being disabled. Additionally inspecting
the downloaded dist-upgrader tarball we can see that the symlink is now
good.

bdmurray at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ file DistUpgrade
DistUpgrade: broken symbolic link to DistUpgrade
bdmurray at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ cat DistUpgradeVersion.py
VERSION = '19.04.16.1'
bdmurray at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-jjhazydt$ cd -
/tmp/ubuntu-release-upgrader-27u554bb
bdmurray at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-27u554bb$ file DistUpgrade
DistUpgrade: symbolic link to .
bdmurray at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-27u554bb$ cat DistUpgradeVersion.py
VERSION = '19.04.16.2'

Setting to verification-done.

** Tags removed: verification-needed verification-needed-disco
** Tags added: verification-done verification-done-disco

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1824430

Title:
  disco dist-upgrader tarball has a broken symlink in it

Status in ubuntu-release-upgrader package in Ubuntu:
  In Progress
Status in ubuntu-release-upgrader source package in Disco:
  Fix Committed

Bug description:
  [Impact]
  The dist upgrade process is running old code from cosmic not the new code from disco, which can cause upgrades to go awry in unexpected ways.

  [Test Case]
  1) mkdir -p /var/snap/canonical-livepatch/common
  2) touch /var/snap/canonical-livepatch/common/machine-token
  3) run do-release-upgrade

  With the version of the dist-upgrader in proposed (obtained via do-
  release-upgrade -p) you will not see the bogus error message cited in
  the original description.

  [Regression Potential]
  None that I can think of, we are fixing a regression here.

  Original Description
  --------------------
  On upgrade from cosmic to disco, I was shown a bogus message about livepatch:

    Livepatch security updates are not available for Ubuntu 19.04. If
  you upgrade, Livepatch will turn off.

  I'm upgrading from cosmic, which has no livepatch support, so I
  shouldn't be shown this message.

  Bug #1816423 seems to be the same symptom, but that is reported as
  fixed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1824430/+subscriptions