[Bug 1855918] Re: show-motd: Show MOTD from /etc/profile.d snippet in the first shell every day

[Balint Reczey]

** Description changed:

- instead of showing it only after 24h is elapsed since showing it last time.
- This is easier to understand
+ [Impact] (Compared to LP: #1855089)
+ 
+  * Users are shown MOTD once a day but only in a shell started at a
+ later hour than the one that showed MOTD the day before. This a bit
+ confusing and harder to predict than showing MOTD in the first started
+ shell every day. This fix implements the latter.
+ 
+ [Test Case]
+  * MOTD should be shown when touch refers to a date yesterday:
+ 
+  $ install show-motd
+  $ touch -d 'now - 23 hours' $HOME/.motd_shown
+  $ . /etc/profile.d/update-motd.sh
+ ...
+  $ touch -d 'now - 25 hours' $HOME/.motd_shown
+  $ . /etc/profile.d/update-motd.sh
+ ...
+  $ touch -d 'now - 1 hour' $HOME/.motd_shown
+  $ . /etc/profile.d/update-motd.sh
+ ...
+ 
+ 
+ [Regression Potential]
+ 
+  * Since this is an improvement of the new functionality only available
+ in -proposed there is no extra regression potential compared to the
+ change introducing the new functionality in LP: #1855089.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-motd in Ubuntu.
https://bugs.launchpad.net/bugs/1855918

Title:
  show-motd: Show MOTD from /etc/profile.d snippet in the first shell
  every day

Status in update-motd package in Ubuntu:
  New
Status in update-motd source package in Eoan:
  New

Bug description:
  [Impact] (Compared to LP: #1855089)

   * Users are shown MOTD once a day but only in a shell started at a
  later hour than the one that showed MOTD the day before. This a bit
  confusing and harder to predict than showing MOTD in the first started
  shell every day. This fix implements the latter.

  [Test Case]
   * MOTD should be shown when touch refers to a date yesterday:

   $ install show-motd
   $ touch -d 'now - 23 hours' $HOME/.motd_shown
   $ . /etc/profile.d/update-motd.sh
  ...
   $ touch -d 'now - 25 hours' $HOME/.motd_shown
   $ . /etc/profile.d/update-motd.sh
  ...
   $ touch -d 'now - 1 hour' $HOME/.motd_shown
   $ . /etc/profile.d/update-motd.sh
  ...

  
  [Regression Potential]

   * Since this is an improvement of the new functionality only
  available in -proposed there is no extra regression potential compared
  to the change introducing the new functionality in LP: #1855089.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-motd/+bug/1855918/+subscriptions