[Bug 1810154] Re: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed

[Łukasz Zemczak]

Hello Andreas, or anyone else affected,

Accepted plymouth into eoan-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/plymouth/0.9.4git20190712-0ubuntu4.1
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-eoan to verification-done-eoan. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-eoan. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: plymouth (Ubuntu Eoan)
       Status: New => Fix Committed

** Tags added: verification-needed verification-needed-eoan

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to plymouth in Ubuntu.
https://bugs.launchpad.net/bugs/1810154

Title:
  ply_boot_client_process_incoming_replies: Assertion `request_node !=
  NULL' failed

Status in plymouth package in Ubuntu:
  Fix Released
Status in plymouth source package in Eoan:
  Fix Committed

Bug description:
  [SRU Justification]
  An Ubuntu-specific patch causes a crash in plymouth that does not occur upstream and breaks one of the standard use cases of the plymouth client, to prompt for passwords.  While the specific error does not affect password prompting for LUKS due to a different invocation of plymouth, it does break password prompting for ZFS encryption, leaving users at an initramfs prompt on boot.

  [Test case]
  1. Change to VT3 on your system (so that you are not under a graphical login session) and log in.
  2. As root, run: plymouthd --mode=boot --attach-to-session --pid-file=/run/plymouth/pid --tty=/dev/tty8; chvt 8; plymouth --show-splash; plymouth ask-for-password --prompt "This is a password prompt" --command="/bin/cat"; plymouth quit; chvt 3
  3. Observe that you are immediately returned to VT3 without being shown a password prompt, and the error message "ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed" is printed on the console.
  4. Install the plymouth package from eoan-proposed.
  5. Repeat step 2.
  6. Observe that you are shown a password prompt.
  7. Type something into the field and hit enter.
  8. Observe that you are returned to VT3 and the text you typed in step 7 has been echoed to the screen, with no error messages.

  [Regression potential]
  This is an Ubuntu-specific bug due to missing handling of a new upstream message type in an Ubuntu-specific patch.  This fixes a crash and has minimal risk of regression.

  
  ubuntu cosmic
  plymouth 0.9.3-1ubuntu10
  initramfs-tools 0.131ubuntu15

  I'm trying to get a password prompt working in the initramfs via
  plymouth, but I get an assertion error.

  This is the sample command I'm running:
  plymouth --debug ask-for-password --command=/bin/cat --prompt "Type something"

  And this is the output I get:
  [./plymouth.c:463]                           on_password_request:Password request
  [ply-event-loop.c:759]               ply_event_loop_stop_watching_fd:stopping watching fd 6
  [ply-event-loop.c:775]               ply_event_loop_stop_watching_fd:removing destination for fd 6
  [./plymouth.c:430]                   on_password_request_execute:executing password request (command /bin/cat)
  [ply-event-loop.c:759]               ply_event_loop_stop_watching_fd:stopping watching fd 6
  [ply-event-loop.c:775]               ply_event_loop_stop_watching_fd:removing destination for fd 6
  [ply-event-loop.c:759]               ply_event_loop_stop_watching_fd:stopping watching fd 6
  [ply-event-loop.c:775]               ply_event_loop_stop_watching_fd:removing destination for fd 6
  plymouth: ./ply-boot-client.c:272: ply_boot_client_process_incoming_replies: Assertion `request_node != NULL' failed.
  Aborted

  plymouth --ping returns 0. It doesn't matter which --command I try.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1810154/+subscriptions