[Bug 1820768] Re: [SRU] support new cab and new docking firmware upgrade in fwupd 1.2.10

[Vic Liu]

I verified following functions in fwupd 1.2.10 on Dell Latitude 5300:

`sudo fwupdmgr refresh`: Could connect to remote server and update metadata.
u at u-Latitude-5300:~$ sudo fwupdmgr refresh
[sudo] password for u: 
Fetching metadata https://cdn.fwupd.org/downloads/firmware.xml.gz
Downloading…             [***************************************]
Fetching signature https://cdn.fwupd.org/downloads/firmware.xml.gz.asc

`sudo fwupdmgr get-devices`: Could show device firmware correctly.
u at u-Latitude-5300:~$ sudo fwupdmgr get-devices
Latitude 5300 System Firmware
  DeviceId:             b03588a447340830af90b63cd5830a54455504fb
  Guid:                 93634829-10b8-4098-a617-d52d056a4dd8
  Plugin:               uefi
  Flags:                internal|updatable|require-ac|supported|registered|needs-reboot
  Version:              0.1.4.1
  VersionLowest:        0.1.4.1
  VersionFormat:        quad
  Icon:                 computer
  Created:              2019-12-27
  UpdateState:          success

PC401 NVMe SK hynix 512GB
  DeviceId:             3743975ad7f64f8d6575a9ae49fb3a8856fe186f
  Guid:                 2260c743-963b-566e-93f1-8223c3e6b87b <- NVME\VEN_1C5C&DEV_1527
  Guid:                 c28fdadd-607d-578c-b6ed-60ac49682904 <- PC401 NVMe SK hynix 512GB
  Serial:               MI88N047510608S6M
  Summary:              NVM Express Solid State Drive
  Plugin:               nvme
  Flags:                internal|updatable|require-ac|registered|needs-reboot
  VendorId:             NVME:0x1C5C
  Version:              80007E00
  VersionFormat:        plain
  Icon:                 drive-harddisk
  Created:              2019-12-27

`sudo fwupdmgr get-updates`: Could get latest update of system firmware from remote server.
u at u-Latitude-5300:~$ sudo fwupdmgr get-updates
Latitude 5300 System Firmware has firmware updates:
Device ID:               b03588a447340830af90b63cd5830a54455504fb
GUID:                    93634829-10b8-4098-a617-d52d056a4dd8
ID:                      com.dell.uefi93634829.firmware
Update Version:          0.1.5.0
Update Name:             Latitude 5X00 System Update Update
Update Summary:          Firmware for the Dell Latitude 5X00
Update Remote ID:        lvfs
Update Checksum:         SHA1(51b9269d0dc93635610f86ce149a7103bc6e5b68)
Update Location:         https://fwupd.org/downloads/ffbf931509f73fd26b410ff8358b51f3eaa20e7f-firmware.cab
Update Description:      Fixes and Enhancements:- Enhances the security of the system. Important - Once the BIOS is upgraded, you cannot downgrade BIOS EXE/ Recovery (RCV) to the versions before 1.2.0 due to restrictions.

`sudo fwupdmgr update`: Could update system firmware successfully from remote server.
u at u-Latitude-5300:~$ sudo fwupdmgr update
BIOS got updated successfully.

`sudo fwupdmgr install ffbf931509f73fd26b410ff8358b51f3eaa20e7f-firmware.cab`: Could update system firmware with local capsule file.
Though if update the same version of system firmware currently running on system, fwupdmgr would not block firmware update even without `--allow-reinstall` option.

u at u-Latitude-5300:~/Downloads$ sudo fwupdmgr install ffbf931509f73fd26b410ff8358b51f3eaa20e7f-firmware.cab 
Decompressing…           [***************************************]
Authenticating…          [***************************************]
Installing on Latitude 5300 System Firmware…                     ]
Scheduling…              [***************************************]

An update requires a reboot to complete. Restart now? [Y|n]:

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to libxmlb in Ubuntu.
Matching subscriptions: foundations-bugs-libxmlb
https://bugs.launchpad.net/bugs/1820768

Title:
  [SRU] support new cab and new docking firmware upgrade in fwupd 1.2.10

Status in OEM Priority Project:
  In Progress
Status in fwupd package in Ubuntu:
  Fix Released
Status in fwupd-signed package in Ubuntu:
  Fix Released
Status in fwupdate package in Ubuntu:
  Fix Released
Status in libxmlb package in Ubuntu:
  Fix Released
Status in fwupd source package in Bionic:
  Fix Committed
Status in fwupd-signed source package in Bionic:
  Fix Committed
Status in fwupdate source package in Bionic:
  Fix Committed
Status in libxmlb source package in Bionic:
  Fix Committed

Bug description:
  * Impact

  Bios vendor is pushing to put the new design into cab file, and also
  new docking DW19 needs the new fwupd to support it.

  That needs new fwupd to support.

  * Background:
   1. most user does firmware update via gnome-software and it talk to fwupd.
   2. only very very limited user will call /usr/bin/fwupdate from the command line.
   3. the new fwupd will need a new fwupd-signed. So we will remove fwupdate-signed.

  * Current test result before we have something in proposed channel:
   1. new fwupd works well with gnome-software, so we should be safe to go.
   2. for those very limited user, they can call /usr/lib/fwupd/fwupdate to replace /usr/bin/fwupdate. so it should be safe to remove fwupdate.

  * Test case

  A.
  1. install the new fwupd, and plugin the new docking - DW19.
  2. fwupdmgr get-devices and check if all internal device can properly show

  B.
  1. If you can get new cab file, try to use fwupdmgr install XX.cab to see if can work properly.

  C.
  1. If you can get a machine that have some firmware update pending, try to go gnome-software, and click refresh with the new fwupd, you should be able to see the pending firmware showed there. Which proves that it can properly be integrated with gnome. (ycheng-twn have a laptop with that condition, and he can verify that one

  D.
  1. Install an 18.04 Ubuntu Desktop system.
  2. Enable bionic-proposed.
  3. Run update-manager.
  4. Ensure that the fwupd and fwupd-signed packages are installed without error.
  5. Ensure that no files or directories from the old fwupdate package are left behind in /boot/efi/EFI/ubuntu, /var/lib/fwupdate, or /var/cache/fwupdate.

  * Regression potential

  Since the upstream maintainer is back up this upgrade, and he also
  works in a major computer vendor and works closely with the BIOS team,
  it should be fairly low risk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1820768/+subscriptions