[Bug 1856863] Re: Ubiquity crashes when partitioning the disk with ZFS installation

[Pablo Mendez Hernandez]

The issue stems from the assumption made by the installer that only EFI
systems need to label disks as GPT. I've created a non-UEFI VM with an 8
GB thin-disk and was able to reproduce the issue, but the following diff
was enough to make the installation to succeed:

---

root at ubuntu:/usr/share/ubiquity# diff -u zsys-setup.orig zsys-setup
--- zsys-setup.orig	2019-12-31 20:53:20.861713613 +0200
+++ zsys-setup	2019-12-31 21:23:50.115938723 +0200
@@ -167,9 +167,11 @@
 	sfdiskopts=""
 	partprefix="${disk}${PARTBASE}"
 
+	labeltype=$(sfdisk -l "${disk}"|grep '^Disklabel type:'|awk '{print $NF}')
+
 	echo "I: Formatting disk $disk with partitions grub:${partgrub} ext:${partext} bpool:${partbpool} rpool:${partrpool}"
 
-	if [ "${IS_EFI}" = "true" ]; then
+	if [ "${IS_EFI}" = "true" -o "${labeltype}" = "gpt" ]; then
 
 		# Improvement: Delete all the partitions but the ESP
 		# We should be only 1 or 2 partittion but well it can be made generic

---

It is a bit rough and doesn't apply to current HEAD (I applied it to the
live image code) but it shows the issue and how it can be
patched/"workarounded".


Regards, and happy new year.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1856863

Title:
  Ubiquity crashes when partitioning the disk with ZFS installation

Status in ubiquity package in Ubuntu:
  Confirmed

Bug description:
  Ubiquity crashes while formatting ZFS disks.

  ProblemType: Bug
  DistroRelease: Ubuntu 19.10
  Package: ubiquity 19.10.21
  ProcVersionSignature: Ubuntu 5.3.0-18.19-generic 5.3.1
  Uname: Linux 5.3.0-18-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu8
  Architecture: amd64
  CasperVersion: 1.427
  Date: Wed Dec 18 16:24:36 2019
  InstallCmdLine: file=/cdrom/preseed/ubuntu.seed initrd=/casper/initrd quiet splash --- maybe-ubiquity
  LiveMediaBuild: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
  SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1856863/+subscriptions