[Bug 1807032] Re: RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable not passed to dist-upgrader tarball

[Launchpad Bug Tracker]

This bug was fixed in the package ubuntu-release-upgrader - 1:18.10.11.3

---------------
ubuntu-release-upgrader (1:18.10.11.3) cosmic; urgency=medium

  * DistUpgrade/DistUpgradeCache.py: When calculating free space needed for
    mount points don't use a negative number as the buffer. (LP: #1786484)
  * fix more typos re RELEASE_UPRADER_ALLOW_THIRD_PARTY.
  * DistUpgrade/DistUpgradeController.py: When rewriting sources.list entries
    check to see if the source provides packages for the release to which the
    upgrade is occurring. If it doesn't the entry is disabled thereby
    improving upgrades with PPAs. (LP: #1807043)
  * do-release-upgrade: add a parameter to allow third party mirrors and
    repositories, additionally pass along the environmental variable
    RELEASE_UPGRADER_ALLOW_THIRD_PARTY via pkexec and sudo. (LP: #1807032)
  * DistUpgrade/DistUpgradeCache.py: improve messaging regarding failures to
    calculate the upgrade and suggest using ppa-purge if PPAs are an issue.
  * DistUpgrade/DistUpgradeCache.py: in the event there is a failure to
    calculate the upgrade provide information about the log files in
    /var/log/dist-upgrade. (LP: #1771387)
  * debian/source_ubuntu-release-upgrader.py: Include xorg_fixup.log if it
    exists.
  * DistUpgrade/xorg_fix_proprietary.py: modify how the system is checked to
    see if nvidia is being used, drop fglrx check since it has been
    deprecated. (LP: #1773637)

 -- Brian Murray <brian at ubuntu.com>  Thu, 20 Dec 2018 12:31:37 -0800

** Changed in: ubuntu-release-upgrader (Ubuntu Cosmic)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1807032

Title:
  RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable not passed to dist-
  upgrader tarball

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Triaged
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Released

Bug description:
  Impact
  ------
  It is not possible to override the dist-upgrader's third party mirror check by an environmental variable, subsequently users are asked a question when they shouldn't be.

  Test Case
  ---------
  The change is in do-release-upgrade and DistUpgradeFetcherCore.py so affects upgrades to the release after the one receiving the SRU e.g. if the SRU is for cosmic test upgrading to disco not cosmic. This needs to be tested for check-new-release-gtk and do-release-upgrade.

  1) Run RELEASE_UPGRADER_ALLOW_THIRD_PARTY=1 /usr/lib/ubuntu-release-upgrader/check-new-release-gtk (or do-release-upgrade and with -d to upgrade to disco)
  2) Choose to proceed with the upgrade

  With the version of ubuntu-release-upgrader in the archive you'll
  receive a dialog (or message for the text upgrader) saying "No valid
  mirror found" and "Do you want to rewrite 'sources.list' anyway?".
  With the version of ubuntu-release-upgrader from -proposed you'll
  receive no such dialog and you can find "WARNING mirror check skipped"
  in /var/log/dist-upgrade/main.log.

  There is no need to complete the full upgrade.

  Regression Potential
  --------------------
  With the pkexec change we are only passing the RELEASE_UPGRADER_ALLOW_THIRD_PARTY env variable on to the release upgrade process but with the do-release-upgrade (DistUpgradeFetcherCore.py / sudo) one we are passing all existing environment variables on which could cause an issue for the release upgrade process.

  [Original Description]
  ubuntu-release-upgrader indicates that RELEASE_UPGRADER_ALLOW_THIRD_PARTY can be set in the environment so that release upgrades will be attempted without commenting out third party mirrors or repositories, however in practice this is untrue. This doesn't work because pkexec is used to call do-release-upgrade, and it doesn't pass on env, and because sudo (used for DistUpgradeViewText) is called with -E. This should be sorted out so that the documentation is not lying and so upgrades with PPAs enabled can be attempted.

  Its possible to confirm the fix for this bug by looking at /var/log
  /dist-upgrade/main.log for a PPA not being commented out or the
  following line:

  2018-12-05 14:23:29,008 WARNING mirror check skipped, *overriden* via
  config

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1807032/+subscriptions