[Bug 1819207] Re: [FFe] Add Modaliases to open-vm-tools-desktop to allow automatic installation by ubuntu-drivers
Launchpad Bug Tracker
1819207 at bugs.launchpad.net
Mon Jun 17 08:53:09 UTC 2019
This bug was fixed in the package open-vm-tools -
2:10.3.10-1~ubuntu0.18.10.1
---------------
open-vm-tools (2:10.3.10-1~ubuntu0.18.10.1) cosmic; urgency=medium
* Backport recent open-vm-tools (LP: #1822204)
open-vm-tools (2:10.3.10-1) unstable; urgency=high
* [122e511] Update upstream source from tag 'upstream/10.3.10'
Update to upstream version '10.3.10'
with Debian dir fb12c7cfc99a9497795475c29306e78d08cc3712
- Closes: #925940
- Bugfix release for the 10.3 series.
- Correct and/or improve handling of certain quiesced
snapshot failures (shipped as patch in 2:10.3.5-6).
- Fix some bad derefs in primary NIC gather code
- Fix possible security issue with the permissions of the
intermediate staging directory and path.
Closes: #925959
- CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate()
Found by coverity.
- Deploypkg log files of linux should not be world readable.
They might contain sensitive data.
- General code clean-up:
- Treat local variables "len" consistently as "size_t"
type in Posix_Getmntent_r()
- Improve readability of error handling logic in
ShrinkDoWipeAndShrink() and remove another line of dead code.
- Setting "errno" to ENOENT when there is no passwd entry
for the user.
- Fix NULL pointer dereference and remove three lines of dead code.
- Other changes/fixes, not related to Debian:
- Update copyright years
- Fix CentOS 7.6 detection
- Include vmware/tools/log.h to define g_info (fix for SLES)
- Special-case profile loading for StartProgram
(Win32 only)
- Changes to common source files not applicable to
open-vm-tools. (Code used by other vmware tools, unrelated
to open-vm-tools).
- Bump up the SYSIMAGE_VERSION for VMware tools 10.3.10
* [18de70f] Removing backported patches, shipped in 10.3.10.
open-vm-tools (2:10.3.5-8) unstable; urgency=medium
[ Jean-Baptiste Lallement ]
* [0f35aee] Add modaliases to open-vm-tools-desktop.
Added Modaliases to open-vm-tools-desktop to auto-discover and
auto-install the driver on Ubuntu via ubuntu-drivers. The driver is then
installed at installation time and available on first boot for an
improved user experience (LP: #1819207)
[ Bernd Zeimetz ]
* [dc4e1ce] Load vmwgfx module before vmtoolsd starts.
As discussed on github in vmware/open-vm-tools#214
we need to load the vmwgfx module before starting vmtoolsd
for desktop users. Otherwise it is not able to retrieve the KMS
resolutions and resizing the VM desktop fails.
Thanks to @thomashvmw @rhertzog (Closes: #924518)
-- Christian Ehrhardt <christian.ehrhardt at canonical.com> Tue, 14 May
2019 09:05:46 +0200
** Changed in: open-vm-tools (Ubuntu Cosmic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1819207
Title:
[FFe] Add Modaliases to open-vm-tools-desktop to allow automatic
installation by ubuntu-drivers
Status in open-vm-tools package in Ubuntu:
Fix Released
Status in ubiquity package in Ubuntu:
Fix Released
Status in ubuntu-drivers-common package in Ubuntu:
Fix Released
Status in open-vm-tools source package in Bionic:
Fix Released
Status in ubiquity source package in Bionic:
Won't Fix
Status in ubuntu-drivers-common source package in Bionic:
Won't Fix
Status in open-vm-tools source package in Cosmic:
Fix Released
Status in ubiquity source package in Cosmic:
Won't Fix
Status in ubuntu-drivers-common source package in Cosmic:
Won't Fix
Status in open-vm-tools source package in Disco:
Fix Released
Status in ubiquity source package in Disco:
Fix Released
Status in ubuntu-drivers-common source package in Disco:
Fix Released
Bug description:
[Rationale]
On Ubuntu Desktop, we want to install automatically at installation time open-vm-tools-desktop and its dependencies to provide an improved user experience on first boot after installation of the guest. This method also provides an easy way to install the drivers after installation if they have not been installed at installation time.
It is achieved adding an XB-Modaliases field to the control file for
the record 'open-vm-tools-desktop' so ubuntu-drivers can detect the
packages to install when running in a VMware guest and adding open-vm-
tools to the list of whitelisted packages in ubuntu-drivers
[Impact]
The change adds an additional field to the control file used by ubuntu-drivers to detect the drivers to install automatically. In the worst case scenario either the field is not added or the detection by ubuntu-drivers fails. In both cases the package o-v-t-desktop is not installed and can still be installed manually.
Note: open-vm-tools-desktop is in universe and for the final feature
(>=Disco) it must be in main (already promoted). But for the SRU
context (as this was accepted by Debian in 10.3.5-8) in our regular
MRE we only cover the open-vm-tools change to "provide" the modalias.
We do not change the ubuntu-drivers or ubiquity to depend on it - so
no need to promote it on the SRU.
[Test Case]
With the patched versions of ubuntu-drivers and open-vm-tools
1. Boot a daily ISO of Ubuntu Desktop to the live session in a VMware Guest (with VMWare Workstation for example)
2. Open a terminal, make sure the package cache is up to date with the version of o-v-t containing the Modaliases field
3. Run the command:
$ ubuntu-drivers list
and verify that o-v-t-desktop is in the output
4. Run the command:
$ ubuntu-drivers devices
And verify that the output shows the details of the sys entry for this device
5. Run the command:
$ sudo ubuntu-drivers install
and verify that the package o-v-t-desktop is installed
[Regression Potential]
Very Low. Package may fail to build if for some reason dh-gencontrol fails. Otherwise, given that the package is not already installed automatically, if automated installation doesn't work then we're still in the same situation than today.
On ubuntu-drivers side, the change just adds o-v-t-desktop to the whitelist using an existing mechanism so other than a typo there is no risk of regression.
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: open-vm-tools-desktop (not installed)
ProcVersionSignature: Ubuntu 4.19.0-13.14-generic 4.19.20
Uname: Linux 4.19.0-13-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu23
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Fri Mar 8 20:02:49 2019
InstallationDate: Installed on 2014-07-15 (1697 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: open-vm-tools
UpgradeStatus: Upgraded to disco on 2018-03-24 (349 days ago)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1819207/+subscriptions
More information about the foundations-bugs
mailing list