[Bug 1737717] Re: unattended-upgrade-shutdown crashes with apt_pkg.Error: E:Syntax error /etc/apt/apt.conf:2: Extra junk at end of file

[Balint Reczey]

There were no relevant changes between .1 and .2 thus marking this bug
as verified on Xenial again.

** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1737717

Title:
  unattended-upgrade-shutdown crashes with apt_pkg.Error: E:Syntax error
  /etc/apt/apt.conf:2: Extra junk at end of file

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Xenial:
  Fix Committed

Bug description:
  [Impact]

   * Unattended-upgrades-shutdown service fails to stop printing a crash
   * The fix would not warrant an SRU itself but it is part of the full backport SRU tracked in LP: #1702793.

  [Test Case]

   * Buggy version:
  root at x-uu-1702793:~#  echo extra-junk >> /etc/apt/apt.conf.d/50unattended-upgrades
  root at x-uu-1702793:~# service unattended-upgrades status
  ● unattended-upgrades.service - Unattended Upgrades Shutdown
     Loaded: loaded (/lib/systemd/system/unattended-upgrades.service; enabled; vendor preset: enabled)
     Active: active (exited) since Fri 2019-02-08 12:55:16 UTC; 39s ago
       Docs: man:unattended-upgrade(8)
      Tasks: 0
     Memory: 0B
        CPU: 0

  Feb 08 12:55:16 x-uu-1702793 systemd[1]: Started Unattended Upgrades Shutdown.
  root at x-uu-1702793:~# service unattended-upgrades stop  
  root at x-uu-1702793:~# service unattended-upgrades status
  ● unattended-upgrades.service - Unattended Upgrades Shutdown
     Loaded: loaded (/lib/systemd/system/unattended-upgrades.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Fri 2019-02-08 12:56:02 UTC; 2s ago
       Docs: man:unattended-upgrade(8)
    Process: 602 ExecStop=/usr/share/unattended-upgrades/unattended-upgrade-shutdown (code=exited, status=1/FAILURE)

  Feb 08 12:55:16 x-uu-1702793 systemd[1]: Started Unattended Upgrades Shutdown.
  Feb 08 12:56:02 x-uu-1702793 systemd[1]: Stopping Unattended Upgrades Shutdown...
  Feb 08 12:56:02 x-uu-1702793 unattended-upgrade-shutdown[602]: Traceback (most recent call last):
  Feb 08 12:56:02 x-uu-1702793 unattended-upgrade-shutdown[602]:   File "/usr/share/unattended-upgrades/unattended-up
  Feb 08 12:56:02 x-uu-1702793 unattended-upgrade-shutdown[602]:     apt_pkg.init_config()
  Feb 08 12:56:02 x-uu-1702793 unattended-upgrade-shutdown[602]: SystemError: E:Syntax error /etc/apt/apt.conf.d/50un
  Feb 08 12:56:02 x-uu-1702793 systemd[1]: unattended-upgrades.service: Control process exited, code=exited status=1
  Feb 08 12:56:02 x-uu-1702793 systemd[1]: Stopped Unattended Upgrades Shutdown.
  Feb 08 12:56:02 x-uu-1702793 systemd[1]: unattended-upgrades.service: Unit entered failed state.
  Feb 08 12:56:02 x-uu-1702793 systemd[1]: unattended-upgrades.service: Failed with result 'exit-code'.

  root at x-uu-1702793:~# service unattended-upgrades start 
  root at x-uu-1702793:~# service unattended-upgrades status
  ● unattended-upgrades.service - Unattended Upgrades Shutdown
     Loaded: loaded (/lib/systemd/system/unattended-upgrades.service; enabled; vendor preset: enabled)
     Active: active (exited) since Fri 2019-02-08 12:56:28 UTC; 2s ago
       Docs: man:unattended-upgrade(8)
    Process: 602 ExecStop=/usr/share/unattended-upgrades/unattended-upgrade-shutdown (code=exited, status=1/FAILURE)

  
   * Fixed version:
  root at dd-uu-ref:~#  echo extra-junk >> /etc/apt/apt.conf.d/50unattended-upgrades

  root at dd-uu-ref:~# service unattended-upgrades status
  ● unattended-upgrades.service - Unattended Upgrades Shutdown
     Loaded: loaded (/lib/systemd/system/unattended-upgrades.service; enabled; vendor preset: enabled)
     Active: active (running) since Fri 2019-02-08 08:59:58 UTC; 3h 42min ago
       Docs: man:unattended-upgrade(8)
   Main PID: 259 (unattended-upgr)
      Tasks: 2 (limit: 4915)
     Memory: 12.4M
     CGroup: /system.slice/unattended-upgrades.service
             └─259 /usr/bin/python3 /usr/share/unattended-upgrades/unattended-upgrade-shutdown --wait-for-signal

  Feb 08 08:59:58 dd-uu-ref systemd[1]: Started Unattended Upgrades Shutdown.
  root at dd-uu-ref:~# service unattended-upgrades stop
  root at dd-uu-ref:~# cat /var/log/unattended-upgrades/unattended-upgrades-shutdown.log 
  2019-02-07 16:08:14,675 WARNING - SIGTERM or SIGHUP received, stopping unattended-upgrades only if it is running
  root at dd-uu-ref:~# service unattended-upgrades status
  ● unattended-upgrades.service - Unattended Upgrades Shutdown
     Loaded: loaded (/lib/systemd/system/unattended-upgrades.service; enabled; vendor preset: enabled)
     Active: inactive (dead) since Fri 2019-02-08 12:50:35 UTC; 7min ago
       Docs: man:unattended-upgrade(8)
    Process: 760 ExecStart=/usr/share/unattended-upgrades/unattended-upgrade-shutdown --wait-for-signal (code=exited,
   Main PID: 760 (code=exited, status=0/SUCCESS)

  Feb 08 12:49:39 dd-uu-ref systemd[1]: Started Unattended Upgrades Shutdown.
  Feb 08 12:50:35 dd-uu-ref systemd[1]: Stopping Unattended Upgrades Shutdown...
  Feb 08 12:50:35 dd-uu-ref systemd[1]: unattended-upgrades.service: Succeeded.

  
  [Regression Potential]

   * U-u.service used to stop crashing, now it exits normally when the APT configuration was valid when it was started. There is little chance for regressing here since the configuration file is not read again.
   * There is also an enhancement request tracked to start u-u-s with a default config when parsing the config fails to be able to act on shutdown:
  https://github.com/mvo5/unattended-upgrades/issues/161

  [Original Bug Text]

  The Ubuntu Error Tracker has been receiving reports about a problem regarding unattended-upgrades.  This problem was most recently seen with package version 0.98ubuntu1, the problem page at https://errors.ubuntu.com/problem/b1c4cd0c858e1c3c6c86f938397e8d5d4208242b contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
  If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

  Traceback (most recent call last):
    File "/usr/share/unattended-upgrades/unattended-upgrade-shutdown", line 136, in <module>
      apt_pkg.init_config()
  apt_pkg.Error: E:Syntax error /etc/apt/apt.conf:2: Extra junk at end of file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1737717/+subscriptions