[Bug 1828072] Re: KernelRemoval section is out of date

[Brian Murray]

I tested this when upgrading from xenial to bionic and this worked well.

root at clean-xenial-amd64:/tmp/ubuntu-release-upgrader-qc5mefel# head -n10 /var/log/dist-upgrade/main.log 
2019-05-09 13:31:56,719 INFO Using config files '['./DistUpgrade.cfg.xenial']'
2019-05-09 13:31:56,719 INFO uname information: 'Linux clean-xenial-amd64 4.15.0-47-generic #50~16.04.1-Ubuntu SMP Fri Mar 15 16:06:21 UTC 2019 x86_64'
2019-05-09 13:31:56,995 INFO apt version: '1.2.31'
2019-05-09 13:31:56,996 INFO python version: '3.5.2 (default, Nov 12 2018, 13:43:14) 
[GCC 5.4.0 20160609]'
2019-05-09 13:31:56,998 INFO release-upgrader version '18.04.32' started
2019-05-09 13:31:57,001 INFO locale: 'en_US' 'UTF-8'
2019-05-09 13:31:57,100 DEBUG Using 'DistUpgradeViewText' view
2019-05-09 13:31:57,136 DEBUG enable dpkg --force-overwrite
2019-05-09 13:31:57,154 DEBUG creating statefile: '/var/log/dist-upgrade/apt-clone_system_state.tar.gz'
root at clean-xenial-amd64:/tmp/ubuntu-release-upgrader-qc5mefel# grep -i obsoletekernel /var/log/dist-upgrade/main.log
2019-05-09 14:09:58,075 DEBUG identifyObsoleteKernels()
2019-05-09 14:10:03,979 DEBUG identifyObsoleteKernels found '{'linux-image-4.4.0-98-generic', 'linux-signed-image-4.4.0-98-generic'}'


** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1828072

Title:
  KernelRemoval section is out of date

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Disco:
  Fix Committed

Bug description:
  The dist-upgrader tarball includes configuration files for the release
  upgrade process and part of the configuration file is a section with
  the heading KernelRemoval which includes Version, BaseNames, and Types
  which are used to build a list of kernels to remove. This section has
  not been updated in quite some time and we should up date so systems
  have less old kernels installed.

  [Test Case]
  1) upgrade a system from a release of Ubuntu to a new release of Ubuntu (this should be done for the following paths B->C, C->D, B->D)
  2) observe the following in /var/log/dist-upgrade/main.log
  "2019-05-07 11:38:23,264 DEBUG identifyObsoleteKernels()
  2019-05-07 11:38:27,621 DEBUG identifyObsoleteKernels found 'set()'"

  The release upgrader from -proposed (do-release-upgrader -p) should
  identify some obsolete kernels ("skipping running kernel linux-
  headers-5.0.0-13-generic") even if it doesn't end up removing them.

  [Regression Potential]
  I made the BaseNames section split out across multiple lines which should be fine but that could cause the config file to fail to be parsed which would probably cause a crash or the same failure to remove obsolete kernels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1828072/+subscriptions