[Bug 1852772] Re: test_updates_interval fails on focal

[Corey Bryant]

My proposed fix for this is:

diff --git a/softwareproperties/dbus/SoftwarePropertiesDBus.py b/softwareproperties/dbus/SoftwarePropertiesDBus.py
index c22f43b..7683a1a 100644
--- a/softwareproperties/dbus/SoftwarePropertiesDBus.py
+++ b/softwareproperties/dbus/SoftwarePropertiesDBus.py
@@ -266,7 +266,7 @@ class SoftwarePropertiesDBus(dbus.service.Object, SoftwareProperties):
     def SetUpdateInterval(self, days, sender=None, conn=None):
         self._check_policykit_privilege(
             sender, conn, "com.ubuntu.softwareproperties.applychanges")
-        self.set_update_interval(days)
+        self.set_update_interval(int(days))

I'd like to get a +1 before uploading that though.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1852772

Title:
  test_updates_interval fails on focal

Status in software-properties package in Ubuntu:
  Triaged

Bug description:
  ======================================================================                                
  FAIL: test_updates_interval (tests.test_dbus.TestDBus)                                                
  ----------------------------------------------------------------------                                
  Traceback (most recent call last):                                                                    
    File "/build/software-properties-0.98.6/tests/test_dbus.py", line 332, in test_updates_interval     
      self.assertTrue('APT::Periodic::Update-Package-Lists "1";' in config)                                                                                                                                   
  AssertionError: False is not true   

  Looking closer, while in the SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py, days is of
  dbus.Int32 type. A simple print output shows:

  days=dbus.Int32(1)

  D-Bus is statically typed, unlike python. More details at:
  https://dbus.freedesktop.org/doc/dbus-python/tutorial.html#data-types

  I think once we're in the dbus method (SetUpdateInterval() method in
  softwareproperties/dbus/SoftwarePropertiesDBus.py) we can convert the
  dbus.Int32 to an int.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1852772/+subscriptions