[Bug 1847300] Re: [backport] magic-proxy: dump proxy log to stdout on failure

[Robert C Jennings]

Test builds with -proposed on xenial, disco, and bionic show that the
proxy log is written to stdout on failure in a binary hook.  Marking
this as verification-done.

** Tags removed: verification-needed verification-needed-bionic verification-needed-disco verification-needed-xenial
** Tags added: verification-done verification-done-bionic verification-done-disco verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1847300

Title:
  [backport] magic-proxy: dump proxy log to stdout on failure

Status in livecd-rootfs package in Ubuntu:
  New
Status in livecd-rootfs source package in Xenial:
  Fix Committed
Status in livecd-rootfs source package in Bionic:
  Fix Committed
Status in livecd-rootfs source package in Disco:
  Fix Committed

Bug description:
  [Impact]

  When we encounter a failure in 'lb binary' the launchpad builders can
  only surface the build output from stdout.  If the binary hook failure
  implicates the archive we can not determine fault without the apt
  proxy log.  Backporting the patch from eoan will dump the proxy log
  to stdout to aid in debugging these failures.

  [Test case]

  Run a build with a $REPO_SNAPSHOT_STAMP and a binary hook with 'exit
  1'.  The apt proxy log should end up on stdout.

  [Regression Potential]

  Nearly none. This dumps a file to stdout in the failure exit path; a
  failure at this stage does not change the outcome of the build.

  [Other Info]

  We are seeing issues today in builds that need this debug output in
  place, we would like to move this SRU through quickly.  The code has
  been running in eoan for at least a week without issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1847300/+subscriptions