[Bug 1850202] [NEW] /etc/grub.d/10_linux_zfs doesn't add savedefault

[Deltik]

Public bug reported:

[Impact]
Ubuntu's ZFS boot support (`/etc/grub.d/10_linux_zfs`) does not add the `savedefault` command to non-recovery entries. This differs from the `/etc/grub.d/10_linux` (without ZFS) behavior, which adds `savedefault` to non-recovery entries.

[Test Case]
1. On a system that has a ZFS root (e.g. one installed with zsys), run `sudo update-grub`.

2. See that there are no mentions of `savedefault` in the relevant
generated section:

    sed -n '/^### BEGIN \/etc\/grub\.d\/10_linux_zfs ###$/,/^### END
\/etc\/grub\.d\/10_linux_zfs ###$/p;/^### END
\/etc\/grub\.d\/10_linux_zfs ###$/q' /boot/grub/grub.cfg | grep
savedefault

If this bug is fixed, the command above will return an output that has
the string "savedefault".

[Regression Potential]
The patch makes the `/etc/grub.d/10_linux_zfs` logic for adding the `savedefault` command the same as that of `/etc/grub.d/10_linux`. It is a behavioral change but restores consistency with the non-ZFS Linux entry generator. The change should only affect those using the `GRUB_SAVEDEFAULT=true` and `GRUB_DEFAULT=saved` options in `/etc/default/grub`.

** Affects: grub2 (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: eoan patch

** Patch added: "/etc/grub.d/10_linux_zfs: Restore missing `savedefault` command generator"
   https://bugs.launchpad.net/bugs/1850202/+attachment/5300961/+files/10_linux_zfs.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1850202

Title:
  /etc/grub.d/10_linux_zfs doesn't add savedefault

Status in grub2 package in Ubuntu:
  New

Bug description:
  [Impact]
  Ubuntu's ZFS boot support (`/etc/grub.d/10_linux_zfs`) does not add the `savedefault` command to non-recovery entries. This differs from the `/etc/grub.d/10_linux` (without ZFS) behavior, which adds `savedefault` to non-recovery entries.

  [Test Case]
  1. On a system that has a ZFS root (e.g. one installed with zsys), run `sudo update-grub`.

  2. See that there are no mentions of `savedefault` in the relevant
  generated section:

      sed -n '/^### BEGIN \/etc\/grub\.d\/10_linux_zfs ###$/,/^### END
  \/etc\/grub\.d\/10_linux_zfs ###$/p;/^### END
  \/etc\/grub\.d\/10_linux_zfs ###$/q' /boot/grub/grub.cfg | grep
  savedefault

  If this bug is fixed, the command above will return an output that has
  the string "savedefault".

  [Regression Potential]
  The patch makes the `/etc/grub.d/10_linux_zfs` logic for adding the `savedefault` command the same as that of `/etc/grub.d/10_linux`. It is a behavioral change but restores consistency with the non-ZFS Linux entry generator. The change should only affect those using the `GRUB_SAVEDEFAULT=true` and `GRUB_DEFAULT=saved` options in `/etc/default/grub`.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1850202/+subscriptions