[Bug 1842902] Re: FFe: create zfs dataset for each user automatically

[Launchpad Bug Tracker]

This bug was fixed in the package shadow - 1:4.5-1.1ubuntu4

---------------
shadow (1:4.5-1.1ubuntu4) eoan; urgency=medium

  * debian/patches/1015_add_zsys_support.patch:
    - Call zsys to handle home directory if available.
    We call zsys to handle dataset creation for zsys system in a separate
    home dataset for each user on the system.
    This allows one to handle user dataset outside of /home and also renaming.
    We don't support yet deletion, as removing the dataset would remove as
    well every snapshot of the history, and so, revert to previous version
    will result in user created, but no home directory, which is unwanted.
    (LP: #1842902)

 -- Didier Roche <didrocks at ubuntu.com>  Thu, 29 Aug 2019 15:00:07 +0200

** Changed in: shadow (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to shadow in Ubuntu.
https://bugs.launchpad.net/bugs/1842902

Title:
  FFe: create zfs dataset for each user automatically

Status in shadow package in Ubuntu:
  Fix Released
Status in zsys package in Ubuntu:
  Fix Released

Bug description:
  Part of the zsys spec is creating/associating one user dataset for
  each HOME user.

  As zsys is an official experimentation for 19.10, we would like to
  include this feature in a safe way, and reachable for any tool
  creating users (adduser, gnome-control-center, ubiquity…). Those are
  using useradd under the scene.

  For this, the proposed implementation:
  - patch useradd trying to execute "zsys useradd create USER HOMEDIR". If zsys isn't present or zsys returns a status code != 0 (which will be the case if the running system isn't a zsys one: pure zfs or non zfs like / on ext4), it will fallback to mkdir. Then the code does the usual chmod()
  - patch usermod, trying as well to execute "zsys useradd rename-home OLDHOME NEWHOME". Same failing reason (not a zsys system, not installed, OLDHOME isn't a zsys handled datasets) and fallback to rename(). Then the code does the usual chmod().

  Tested with and without zsys installed, the code does what we expect.

  I'm attaching the shadow (useradd/usermod) patches, as you can see it's very minimal.
  A new ZSYS release will be needed (https://github.com/ubuntu/zsys). As you can see, there are quite some commits since the last release, but it's all baked (as usual) by a huge suite of tests (in ZFS and machine layers) with corner cases tested and such. I'm confident on that change.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/1842902/+subscriptions