[Bug 1889190] Re: ldconfig is still deferred in libc6.preinst

[Balint Reczey]

** Description changed:

  [Impact]
  
-  * Upgrade from Bionic to Focal may break
-  * The upload really forces 
+  * Upgrade from Bionic to Focal may break if LDCONFIG_TRIGGER_DEBUG is set
+  * The upload really forces
  
  [Test Case]
  
  $ lxc launch ubuntu:bionic bb-glibc-upgrade
- $ lxc shell bb-glibc-upgrade 
+ $ lxc shell bb-glibc-upgrade
  # export LDCONFIG_TRIGGER_DEBUG=1
  #  apt update -qq && apt upgrade -qq -y && do-release-upgrade -d
  ...
  
  With the broken version the following message can be observed:
  ..
  Preparing to unpack .../libc6_2.31-0ubuntu9_amd64.deb ...
  
  Progress: [ 38%]
  ldconfig: wrapper deferring update (trigger activated)
  ...
  
  The fixed version runs ldconfig immediately after unpacking libc6.
  
- 
- [Regression Potential] 
+ [Regression Potential]
  
  * Very small, the fix is literally adding one single character to
- properly set LDCONFIG_NOTRIGGER.
+ properly set LDCONFIG_NOTRIGGER. Running ldconfig immediately as
+ originally planned does not seem to cause issues.
  
  [Other Info]
  
- Fix: 
+ Fix:
  --- a/debian/debhelper.in/libc.preinst
  +++ b/debian/debhelper.in/libc.preinst
  @@ -22,7 +22,7 @@ kfreebsd_compare_versions () {
-  # libcrypt1 breaks/replaces libc6 (<< 2.31). cannot use a pre-depends on libcrypt1
-  # call ldconfig unconditionally for the first libc6 depending on libcrypt1
-  if [ -n "$preversion" ] && dpkg --compare-versions "$preversion" lt 2.31-0ubuntu2; then
+  # libcrypt1 breaks/replaces libc6 (<< 2.31). cannot use a pre-depends on libcrypt1
+  # call ldconfig unconditionally for the first libc6 depending on libcrypt1
+  if [ -n "$preversion" ] && dpkg --compare-versions "$preversion" lt 2.31-0ubuntu2; then
  -       LCONFIG_NOTRIGGER=y
  +       LDCONFIG_NOTRIGGER=y
-         export LDCONFIG_NOTRIGGER
-         ldconfig || ldconfig --verbose
-  fi
+         export LDCONFIG_NOTRIGGER
+         ldconfig || ldconfig --verbose
+  fi

** Description changed:

  [Impact]
  
   * Upgrade from Bionic to Focal may break if LDCONFIG_TRIGGER_DEBUG is set
-  * The upload really forces
+  * The fix really forces ldconfig to run immediately
  
  [Test Case]
  
  $ lxc launch ubuntu:bionic bb-glibc-upgrade
  $ lxc shell bb-glibc-upgrade
  # export LDCONFIG_TRIGGER_DEBUG=1
  #  apt update -qq && apt upgrade -qq -y && do-release-upgrade -d
  ...
  
  With the broken version the following message can be observed:
  ..
  Preparing to unpack .../libc6_2.31-0ubuntu9_amd64.deb ...
  
  Progress: [ 38%]
  ldconfig: wrapper deferring update (trigger activated)
  ...
  
  The fixed version runs ldconfig immediately after unpacking libc6.
  
  [Regression Potential]
  
  * Very small, the fix is literally adding one single character to
  properly set LDCONFIG_NOTRIGGER. Running ldconfig immediately as
  originally planned does not seem to cause issues.
  
  [Other Info]
  
  Fix:
  --- a/debian/debhelper.in/libc.preinst
  +++ b/debian/debhelper.in/libc.preinst
  @@ -22,7 +22,7 @@ kfreebsd_compare_versions () {
   # libcrypt1 breaks/replaces libc6 (<< 2.31). cannot use a pre-depends on libcrypt1
   # call ldconfig unconditionally for the first libc6 depending on libcrypt1
   if [ -n "$preversion" ] && dpkg --compare-versions "$preversion" lt 2.31-0ubuntu2; then
  -       LCONFIG_NOTRIGGER=y
  +       LDCONFIG_NOTRIGGER=y
          export LDCONFIG_NOTRIGGER
          ldconfig || ldconfig --verbose
   fi

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to glibc in Ubuntu.
https://bugs.launchpad.net/bugs/1889190

Title:
  ldconfig is still deferred in libc6.preinst

Status in glibc package in Ubuntu:
  New
Status in glibc source package in Focal:
  New

Bug description:
  [Impact]

   * Upgrade from Bionic to Focal may break if LDCONFIG_TRIGGER_DEBUG is set
   * The fix really forces ldconfig to run immediately

  [Test Case]

  $ lxc launch ubuntu:bionic bb-glibc-upgrade
  $ lxc shell bb-glibc-upgrade
  # export LDCONFIG_TRIGGER_DEBUG=1
  #  apt update -qq && apt upgrade -qq -y && do-release-upgrade -d
  ...

  With the broken version the following message can be observed:
  ..
  Preparing to unpack .../libc6_2.31-0ubuntu9_amd64.deb ...

  Progress: [ 38%]
  ldconfig: wrapper deferring update (trigger activated)
  ...

  The fixed version runs ldconfig immediately after unpacking libc6.

  [Regression Potential]

  * Very small, the fix is literally adding one single character to
  properly set LDCONFIG_NOTRIGGER. Running ldconfig immediately as
  originally planned does not seem to cause issues.

  [Other Info]

  Fix:
  --- a/debian/debhelper.in/libc.preinst
  +++ b/debian/debhelper.in/libc.preinst
  @@ -22,7 +22,7 @@ kfreebsd_compare_versions () {
   # libcrypt1 breaks/replaces libc6 (<< 2.31). cannot use a pre-depends on libcrypt1
   # call ldconfig unconditionally for the first libc6 depending on libcrypt1
   if [ -n "$preversion" ] && dpkg --compare-versions "$preversion" lt 2.31-0ubuntu2; then
  -       LCONFIG_NOTRIGGER=y
  +       LDCONFIG_NOTRIGGER=y
          export LDCONFIG_NOTRIGGER
          ldconfig || ldconfig --verbose
   fi

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1889190/+subscriptions