[Bug 1888916] Re: upgrade from bionic to focal a server with molly-guard moves back sources.list to bionic entries

[Brian Murray]

I tried upgrading again with the /etc/molly-guard/rc changes on both an
Ubuntu 18.04 LTS desktop install (logged in via GUI) and a lxc container
(connected via ssh) and in neither case were the sources.list files set
back to bionic.

To finish the upgrade, a restart is required. 
If you select 'y' the system will be restarted. 

Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot: 
Good thing I asked; I won't reboot precious-dove ...

=== Command detached from window (Tue Aug  4 15:22:14 2020) ===ubuntu at precious-dove:~$ grep bionic /etc/apt/sources.list
# deb-src http://192.168.10.7/ubuntu bionic main restricted
# deb-src http://192.168.10.7/ubuntu bionic-updates main restricted
# deb-src http://192.168.10.7/ubuntu bionic universe
# deb-src http://192.168.10.7/ubuntu bionic-updates universe
# deb-src http://192.168.10.7/ubuntu bionic multiverse
# deb-src http://192.168.10.7/ubuntu bionic-updates multiverse
# deb-src http://192.168.10.7/ubuntu bionic-backports main restricted universe multiverse
# deb http://archive.canonical.com/ubuntu bionic partner
# deb-src http://archive.canonical.com/ubuntu bionic partner
# deb-src http://192.168.10.7/ubuntu bionic-security main restricted
# deb-src http://192.168.10.7/ubuntu bionic-security universe
# deb-src http://192.168.10.7/ubuntu bionic-security multiverse

bdmurray at clean-bionic-amd64:~$ tail /var/log/dist-upgrade/screenlog.0

To finish the upgrade, a restart is required. 
If you select 'y' the system will be restarted. 

Continue [yN] y
I: molly-guard: reboot is always molly-guarded on this system.
Please type in hostname of the machine to reboot: 
Good thing I asked; I won't reboot clean-bionic-amd64 ...

=== Command detached from window (Tue Aug  4 08:52:24 2020) ===bdmurray at clean-bionic-amd64:~$ cat /etc/apt/sources.list
deb http://192.168.10.7/ubuntu focal main restricted universe multiverse
deb http://192.168.10.7/ubuntu focal-updates main restricted universe multiverse
# deb http://archive.ubuntu.com/ubuntu bionic-proposed main restricted universe multiverse
deb http://192.168.10.7/ubuntu focal-security main restricted universe multiverse
deb-src http://192.168.10.7/ubuntu focal main restricted universe multiverse
deb-src http://192.168.10.7/ubuntu focal-updates main restricted universe multiverse
# deb-src http://archive.ubuntu.com/ubuntu bionic-proposed main restricted universe multiverse
deb-src http://192.168.10.7/ubuntu focal-security main restricted universe multiverse

Additionally, the dist-upgrader code wouldn't restore sources.list
(afaict) if the reboot failed.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1888916

Title:
  upgrade from bionic to focal a server with molly-guard moves back
  sources.list to bionic entries

Status in ubuntu-release-upgrader package in Ubuntu:
  Incomplete
Status in ubuntu-release-upgrader source package in Groovy:
  Incomplete

Bug description:
  I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to
  Focal, with molly-guard installed on it - molly-guard configured to
  always ask for the hostname.

  After it has finished:

  ```
  System upgrade is complete.

  Restart required

  To finish the upgrade, a restart is required. 
  If you select 'y' the system will be restarted. 

  Continue [yN] y
  I: molly-guard: reboot is always molly-guarded on this system.
  Please type in hostname of the machine to reboot: 
  Good thing I asked; I won't reboot bates ...

  
  === Command detached from window (Tue Jul 21 15:23:36 2020) ===

  === Command terminated normally (Tue Jul 21 15:23:46 2020) ===
  ```

  It doesn't alert you it was restoring original state of sources.list. 
  After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions