[Bug 1822672] Re: popularity-contest is broken due to a bad merge with debian

[Andrey Bondarenko]

Changing SUBMITURLS is not enough to fix this bug.

popcon-upload script contains bad regexp at line 38

my ($host) = $submiturl =~ m%http://([^/]+)%;

This regexp matches only to HTTP, but not HTTPS schema. Upload finishes
successfully if I change regexp to

my ($host) = $submiturl =~ m%https?://([^/]+)%;

The issue also exists in upstream version 1.69

https://salsa.debian.org/popularity-contest-team/popularity-
contest/blob/160a59f1090b4913180d789c4236d6d3ddb44af6/popcon-upload#L38

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to popularity-contest in Ubuntu.
https://bugs.launchpad.net/bugs/1822672

Title:
  popularity-contest is broken due to a bad merge with debian

Status in popularity-contest package in Ubuntu:
  Confirmed

Bug description:
  I was curious how statistics are submitted by popularity-contest, so I
  checked:

  marc at ellen:~$ sudo bash -x /etc/cron.daily/popularity-contest 
  […]
  + for URL in $SUBMITURLS
  + setsid /usr/share/popularity-contest/popcon-upload -u https://popcon.ubuntu.com/popcon-submit.cgi -f /var/log/popularity-contest.new -C
  + logger -t popularity-contest 'unable to submit report to https://popcon.ubuntu.com/popcon-submit.cgi.'
  […]

  When run manually, the error is:

  marc at ellen:~$ /usr/share/popularity-contest/popcon-upload -u https://popcon.ubuntu.com/popcon-submit.cgi -f /var/log/popularity-contest.new -C -d
  Unable to parse url
  Expected 'PeerHost' at /usr/share/popularity-contest/popcon-upload line 75.

  The URL https://popcon.ubuntu.com/popcon-submit.cgi is set in
  /usr/share/popularity-contest/default.conf

  I noticed that /usr/share/popularity-contest/popcon-upload contains
  hardcoded sequences of "http:", so I tried to manually run popcon-
  upload with "-u http://popcon.ubuntu.com/popcon-submit.cgi". Turns
  out, it works:

  marc at ellen:~$ /usr/share/popularity-contest/popcon-upload -u
  http://popcon.ubuntu.com/popcon-submit.cgi -f /var/log/popularity-
  contest.new -C -d

  I suppose this is globally broken since the URL was changed to https,
  but the script was not updated to support https.

  ProblemType: Bug
  DistroRelease: Ubuntu 19.04
  Package: popularity-contest 1.67ubuntu2
  ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1
  Uname: Linux 5.0.0-8-generic x86_64
  ApportVersion: 2.20.10-0ubuntu23
  Architecture: amd64
  CurrentDesktop: LXQt
  Date: Mon Apr  1 21:10:33 2019
  InstallationDate: Installed on 2016-01-20 (1166 days ago)
  InstallationMedia: Xubuntu 15.10 "Wily Werewolf" - Release amd64 (20151021)
  PackageArchitecture: all
  SourcePackage: popularity-contest
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/popularity-contest/+bug/1822672/+subscriptions