[Bug 1100174] Re: ubiquity crash when installing if there are 2 systems and one of them is Ubuntu

[Launchpad Bug Tracker]

[Expired for ubiquity (Ubuntu) because there has been no activity for 60
days.]

** Changed in: ubiquity (Ubuntu)
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1100174

Title:
  ubiquity crash when installing if there are 2 systems and one of them
  is Ubuntu

Status in ubiquity package in Ubuntu:
  Expired

Bug description:
  I found that when installing Ubuntu 12.04,  if there are two systems
  on the hard disk, and one is Ubuntu,  then ubiquity  will carsh.  I
  checked the code of ubiquity on 3 versions, they are ubiquity_2.10.20,
  ubiquity_2.12.14 and ubiquity_2.13.7, then I found somewhere is
  doubtful.

  Now I will describe the questions:
  in ubi-partman.py file, there is a function named 'calculate_autopartitioning_options()',  when the codes go to 'elif os_count == 2 and len(ubuntu_systems) == 1:',  we can see the codea are :

      elif os_count == 2 and len(ubuntu_systems) == 1:
              if 'replace' in self.extra_options:            (1)
                  ubuntu = ubuntu_systems[0]               (2)
                  q = 'ubiquity/partitioner/ubuntu_format'  (3)
                  self.db.subst(q, 'CURDISTRO', ubuntu)        (4)
                  title = self.description(q)                                (5)
                  desc = self.extended_description(q)            (6)
                  opt = PartitioningOption(title, desc)            (7)
                  options['replace'] = opt                                   (8)

              q = 'ubiquity/partitioner/ubuntu_and_os_format'                                  (9)
              system = (set(operating_systems) - set(ubuntu_systems)).pop()         (10)
              self.db.subst(q, 'OS', system)                               (11)       
              self.db.subst(q, 'CURDISTRO', ubuntu)             (12)
              title = self.description(q)                                     (13)
              desc = self.extended_description(q)                 (14)
              opt = PartitioningOption(title, desc)                 (15)
              options['use_device'] = opt                                  (16)  

  
  somewhere I don't understand is that when the judgement of (1) is false,  in that way, the variable of 'ubuntu' in (2) is not defined.

  but out of the 'if', when codes go to (12), ubiquity uses the variable
  of 'ubuntu', whether it leads to crash?

  I don't know whether my understanding is correct, but I need to
  display the question.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1100174/+subscriptions