[Bug 1867366] Re: hostnqn fails to automatically generate after installing nvme-cli

[Dan Streetman]

@rafaeldtinoco if you have a minute could you review the upload for this for focal? specifically, because the 1.9-1 package version included hardcoded (generated at build time) uuid in /etc/nvme/hostid, i added code in the postinst to replace that value with a install-time generated uuid (so it's unique per host system).
http://launchpadlibrarian.net/495790426/nvme-cli_1.9-1_1.9-1ubuntu0.1.diff.gz

My concern is what the impact might be for anyone actually using the
hardcoded hostid uuid, and if it's better to just leave the old (non-
unique) hostid instead of forcibly replacing it with a unique id.

I will note that in groovy, i didn't add any code to replace existing
hardcoded hostid; any groovy system that started with the 1.12-1 package
version will keep the non-unique hostid. However since groovy isn't
released yet, any groovy system installed after GA would get the fixed
package (and a unique hostid uuid).

In bionic, the package doesn't create /etc/nvme/* files so it's not an
issue there; in fact, the /etc/nvme/* files don't appear to have been
created for any version earlier than focal, so the 1.9-1 and 1.12-1
versions appear to be the only ones containing non-unique
/etc/nvme/hostid values (and no version contained anything in the
/etc/nvme/hostnqn file, since the 'gen-hostnqn' command has always been
broken until fixed in 1.12-1ubuntu1)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to nvme-cli in Ubuntu.
https://bugs.launchpad.net/bugs/1867366

Title:
  hostnqn fails to automatically generate after installing nvme-cli

Status in nvme-cli package in Ubuntu:
  Fix Released
Status in nvme-cli source package in Bionic:
  In Progress
Status in nvme-cli source package in Focal:
  In Progress
Status in nvme-cli source package in Groovy:
  Fix Released
Status in nvme-cli package in Debian:
  Unknown

Bug description:
  [impact]

  "nvme gen-hostnqn" does not work, leading to no content in
  /etc/nvme/hostnqn

  [test case]

  ddstreet at thorin:~$ cat /etc/nvme/hostnqn

  ddstreet at thorin:~$ nvme gen-hostnqn
  "gen-hostnqn" not supported. Install lib uuid and rebuild.

  [regression potential]

  any regression would likely involve a failure of nvme to interact with
  nvmeof devices, or for other systems connecting to this nvme fabric
  target to encounter errors

  also, the upload for Focal includes a postinst check for the hardcoded
  hostid value (from the 1.9-1 package), and if it's found, it
  regenerates it (so the host has a unique generated value). Anyone
  using the old hardcoded hostid will be affected by this

  [scope]

  xenial does not include the gen-hostnqn command, so this is needed
  only for bionic and later.

  note that in bionic, the 'gen-hostnqn' command exists, but the
  /etc/nvme/hostnqn file is not provided by the package.

  [other info]

  to fix this in debian:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969183
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969340

  [original description]

  hostnqn fails to automatically generate after installing nvme-cli

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: nvme-cli 1.9-1
  ProcVersionSignature: Ubuntu 5.4.0-9.12-generic 5.4.3
  Uname: Linux 5.4.0-9-generic x86_64
  ApportVersion: 2.20.11-0ubuntu18
  Architecture: amd64
  Date: Fri Mar  6 14:09:20 2020
  Dependencies:
   gcc-9-base 9.2.1-21ubuntu1
   libc6 2.30-0ubuntu3
   libgcc1 1:9.2.1-21ubuntu1
   libidn2-0 2.2.0-2
   libunistring2 0.9.10-2
  InstallationDate: Installed on 2020-03-05 (0 days ago)
  InstallationMedia: Ubuntu-Server 20.04 LTS "Focal Fossa" - Alpha amd64 (20200124)
  ProcEnviron:
   TERM=xterm
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: nvme-cli
  UpgradeStatus: No upgrade log present (probably fresh install)
  modified.conffile..etc.nvme.hostnqn: [modified]
  mtime.conffile..etc.nvme.hostnqn: 2020-03-06T11:27:08.674276

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1867366/+subscriptions