[Bug 1867366] Re: hostnqn fails to automatically generate after installing nvme-cli

[Rafael David Tinoco]

Let's say someone created a hostnqn by hand and kept the same hard-coded
uuid. This upgrade would brake this scenario.

+    if [ "$2" = "1.9-1" ]; then
+        # the hostid was hardcoded into the binary package, so if the
+        # local file matches the 1.9-1 version hardcoded value,
+        # remove the file so it is properly generated below
+        if [ -s /etc/nvme/hostid ] && [ "$(cat /etc/nvme/hostid)" = "9ce77162-5a3e-439b-a73f-cdf2449521b6" ]; then
+            echo "REMOVING non-unique /etc/nvme/hostid value"
+            rm -f /etc/nvme/hostid
+        fi
+
+        # bug in 1.9-1 build caused hostnqn to contain only a newline,
+        # which fails the "! -s" check below, so just remove the almost-empty
+        # file, so it is properly generated below
+        if [ -s /etc/nvme/hostnqn ] && [ -z "$(cat /etc/nvme/hostnqn)" ]; then
+            rm -f /etc/nvme/hostnqn
+        fi
+    fi

Perhaps we could change it with what I said in last comment: If no
hostnqn is given, then there is no way a fabric was configured, and
you're safe to delete both files. If there is a hostnqn file, you issue
a warning saying for the user the UUID should be changed (if default)
and the fabric should be reviewed.

How does that sound ?

What about Bionic ?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to nvme-cli in Ubuntu.
https://bugs.launchpad.net/bugs/1867366

Title:
  hostnqn fails to automatically generate after installing nvme-cli

Status in nvme-cli package in Ubuntu:
  Fix Released
Status in nvme-cli source package in Bionic:
  In Progress
Status in nvme-cli source package in Focal:
  Incomplete
Status in nvme-cli source package in Groovy:
  Fix Released
Status in nvme-cli package in Debian:
  Unknown

Bug description:
  [impact]

  "nvme gen-hostnqn" does not work, leading to no content in
  /etc/nvme/hostnqn

  [test case]

  ddstreet at thorin:~$ cat /etc/nvme/hostnqn

  ddstreet at thorin:~$ nvme gen-hostnqn
  "gen-hostnqn" not supported. Install lib uuid and rebuild.

  [regression potential]

  any regression would likely involve a failure of nvme to interact with
  nvmeof devices, or for other systems connecting to this nvme fabric
  target to encounter errors

  also, the upload for Focal includes a postinst check for the hardcoded
  hostid value (from the 1.9-1 package), and if it's found, it
  regenerates it (so the host has a unique generated value). Anyone
  using the old hardcoded hostid will be affected by this

  [scope]

  xenial does not include the gen-hostnqn command, so this is needed
  only for bionic and later.

  note that in bionic, the 'gen-hostnqn' command exists, but the
  /etc/nvme/hostnqn file is not provided by the package.

  [other info]

  to fix this in debian:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969183
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969340

  [original description]

  hostnqn fails to automatically generate after installing nvme-cli

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: nvme-cli 1.9-1
  ProcVersionSignature: Ubuntu 5.4.0-9.12-generic 5.4.3
  Uname: Linux 5.4.0-9-generic x86_64
  ApportVersion: 2.20.11-0ubuntu18
  Architecture: amd64
  Date: Fri Mar  6 14:09:20 2020
  Dependencies:
   gcc-9-base 9.2.1-21ubuntu1
   libc6 2.30-0ubuntu3
   libgcc1 1:9.2.1-21ubuntu1
   libidn2-0 2.2.0-2
   libunistring2 0.9.10-2
  InstallationDate: Installed on 2020-03-05 (0 days ago)
  InstallationMedia: Ubuntu-Server 20.04 LTS "Focal Fossa" - Alpha amd64 (20200124)
  ProcEnviron:
   TERM=xterm
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: nvme-cli
  UpgradeStatus: No upgrade log present (probably fresh install)
  modified.conffile..etc.nvme.hostnqn: [modified]
  mtime.conffile..etc.nvme.hostnqn: 2020-03-06T11:27:08.674276

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1867366/+subscriptions