[Bug 1921626] Re: size mismatch error if request of unknown size is larger than others

[Launchpad Bug Tracker]

This bug was fixed in the package apt - 2.2.3

---------------
apt (2.2.3) unstable; urgency=medium

  * tests: Check for and discard expected warning from MaybeAddAuth. For some
    reason, this was only noticed with LTO enabled, but should be a general
    issue.
  * Fix downloads of unsized files that are largest in pipeline (LP: #1921626)
  * Warn on packages without a Size field. Such repositories are broken and
    need to be fixed, as we do not test apt against them, see the bug above
    for more details. Set Acquire::AllowUnsizedPackages to disable the
    warning.

 -- Julian Andres Klode <jak at debian.org>  Tue, 13 Apr 2021 17:53:32
+0200

** Changed in: apt (Ubuntu Hirsute)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1921626

Title:
  size mismatch error if request of unknown size is larger than others

Status in apt package in Ubuntu:
  Fix Released
Status in apt source package in Bionic:
  New
Status in apt source package in Focal:
  New
Status in apt source package in Groovy:
  New
Status in apt source package in Hirsute:
  Fix Released

Bug description:
  [Impact]

  Downloads fail if:

  - there is at least one package each with Size and no size on a mirror
  - a package without a Size field is larger than a package with a Size field that's currently in the pipeline

  Also, this was silent, we need to add an error so people fix repos.
  For hirsute, this is a warning; for hirsute+1 it's an error so
  people's CI fails on them and doesn't "succeed with warnings"

  [Test plan]

  We have included a test case in the apt integration tests, which
  downloads three packages a, b, c where b is largest and has no Size
  field. With 2.2.2, it fails; with 2.2.3 it succceeds.

  We have also added a test case that a warning is shown.

  [Where problems could occur]
  Problems can only occur if you try to download packages without a Size field, as that is the only place code changes (adding code guarded with if ... Size ... == 0; 0 being unknown size).

  [Other changes]
  2.2.3 includes the same change as 2.2.2ubuntu1

  [Original bug report]

  1) Ubuntu 18.04.5 LTS

  2) apt 1.6.12ubuntu0.2

  3) What you expected to happen

  I set a custom set of repositories in /etc/apt/sources.list and then I
  run "apt install <list of packages>". I expect the command to download
  and install the packages.

  4) What happened instead

  "apt install ..." fails during the download phase with "File has
  unexpected size ...."

  5) What I've established trying to debug the issue:

  - Disabling http pipelining resolves the issue: "apt -oAcquire::http::Pipeline-Depth=0 install ..."
  - All the packages, and repo metadata in the referenced repositories is correct
  - The issue is easily reproducible in my setup with different repositories
  - tcpdump shows that requests and responses are in the correct order, and contain the correct data

  More details about the issue:
  https://projects.theforeman.org/issues/32178

  With all the above in mind, it appears that this must be a bug in apt's http pipeline handling.
  It seem that apt is trying to match a request to do wrong response, and size doesn't match.

  I've attached an example log, where the error pops up for multiple
  packages, and they all appear to be compared to one size (86464
  bytes). That size is correct for one of the package being downloaded,
  but somehow apt is trying to match to multiple other packages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1921626/+subscriptions