[Bug 1926298] Re: Segfault added in the recent changes

[Dan Bungert]

Marking confirmed as I can see a segfault, but mine looks a little
different:

Thread 1 "update-notifier" received signal SIGSEGV, Segmentation fault.
show_next_hook (hooks=0x555555778340 = {...}, ta=<optimized out>, ta=<optimized out>) at hooks.c:376
376           gtk_widget_hide(priv->button_next);
(gdb) bt
#0  show_next_hook (hooks=0x555555778340 = {...}, ta=0x5555556c9000, ta=<optimized out>) at hooks.c:376
#1  0x000055555555efdc in show_hooks (focus_on_map=0, ta=0x5555556c9000) at hooks.c:609
#2  check_update_hooks (ta=0x5555556c9000) at hooks.c:858
#3  0x000055555555f268 in hook_tray_icon_init (ta=<optimized out>) at hooks.c:969
#4  0x000055555555c933 in tray_icons_init (un=0x5555556e4f70) at update-notifier.c:447
#5  0x00007ffff7351e38 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#6  0x00007ffff735174f in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#7  0x00007ffff73a4c68 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#8  0x00007ffff7350db3 in g_main_loop_run () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9  0x00007ffff7a4517d in gtk_main () at /lib/x86_64-linux-gnu/libgtk-3.so.0
#10 0x000055555555c0f5 in main (argc=<optimized out>, argv=<optimized out>) at update-notifier.c:649

I like your suggestion to use g_find_program_in_path and plan to use
that if at all possible.

** Changed in: update-notifier (Ubuntu)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1926298

Title:
  Segfault added in the recent changes

Status in update-notifier package in Ubuntu:
  Confirmed

Bug description:
  The issue is new using https://code.launchpad.net/~dbungert/update-
  notifier/+git/update-notifier/+merge/397367 , the previous revision
  didn't have the issue

  * Create a file 'bug'

  'Name: bug
  Priority: Low
  Command: "/bin/true"
  DisplayIf: /bin/true
  Description: update notifier bug'

  and copy it to /var/lib/update-notifier/user.d

  ->  update-notifier segfaults

  (gdb) bt
  #0  0x00007ffff718c769 in __GI___libc_free (mem=0x5550000aa7f9) at malloc.c:3288
  #1  0x00007ffff7365215 in g_strfreev (str_array=<optimized out>) at ../../../glib/gstrfuncs.c:2553
  #2  g_strfreev (str_array=0x5555555d9e00) at ../../../glib/gstrfuncs.c:2546
  #3  0x000055555555dd2d in hook_command_exists (cmd=0x555555702600 "\"/usr/bin/eog\"") at hooks.c:137
  #4  0x000055555555fd6e in is_hook_relevant (hook_file=0x555555829e7b "apt-file.update-notifier")
      at hooks.c:717
  #5  0x000055555555ffb1 in check_update_hooks (ta=0x5555556c9a20) at hooks.c:781
  #6  0x0000555555560715 in hook_tray_icon_init (ta=0x5555556c9a20) at hooks.c:969
  #7  0x000055555555cd77 in tray_icons_init (un=0x55555562c3e0, 

  
  It seems likely to be the error on top of the weekly report for hirsute but that's missing a stacktrace

  
  One comment in addition on the change there, was the env split + iterate over pathdirs basically a re-implementation of https://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-find-program-in-path ? If there is particular reason to do that I would recommend just using the glib function instead (which might also fix the issue as a side effect, I didn't check)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926298/+subscriptions