[Bug 1800544] Re: nvme-cli drops bash completion file in wrong location

[Heitor Alves de Siqueira]

Validated package from -proposed according to test case from
description. Tab completion works correctly, and the bash completion
script is found under the correct location:

$ dpkg -l | grep nvme-cli
ii  nvme-cli                         1.5-1ubuntu1.2                      amd64        userspace tooling to control NVMe drives

$ nvme <TAB>
admin-passthru   delete-ns        flush            get-ns-id        io-passthru      memblaze         resv-report      smart-log-add
attach-ns        detach-ns        format           get_feature      list             read             security-recv    subsystem-reset
compare          disconnect       fw-activate      help             list-ctrl        reset            security-send    version
connect          discover         fw-download      id-ctrl          list-ns          resv-acquire     set-feature      write
connect-all      dsm              fw-log           id-ns            list-subsys      resv-register    show-regs        write-uncor
create-ns        error-log        get-log          intel            lnvm             resv-release     smart-log        write-zeroes

$ file /usr/share/bash-completion/completions/nvme
/usr/share/bash-completion/completions/nvme: ASCII text


** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to nvme-cli in Ubuntu.
https://bugs.launchpad.net/bugs/1800544

Title:
  nvme-cli drops bash completion file in wrong location

Status in nvme-cli package in Ubuntu:
  Fix Released
Status in nvme-cli source package in Bionic:
  Fix Committed
Status in nvme-cli source package in Cosmic:
  Won't Fix

Bug description:
  [impact]

  The nvme-cli tool includes a bash completion script, but it drops it
  in the wrong location.  This prevents it from actually being sourced
  and so the nvme tool doesn't do param autocompletion.

  [test case]

  install the nvme-cli package and try to auto-complete any of its
  params.  They do not auto-complete.

  check if the bash auto-completion script is correctly located at:
  /usr/share/bash-completion/completions/nvme

  [regression potential]

  moving where this bash autocompletion file is only has the potential
  to break nvme's autocompletion.

  [scope]

  fixed upstream in commit df3a06243da0433d8737cdbfa0e3ac101a3a330e

  that is included starting in version 1.7, so Eoan and later are
  already fixed.  This package does not provide any bash completion
  script in Xenial.  So only Bionic needs fixing.

  [other info]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1800544/+subscriptions