[Bug 1951988] Re: dpkg-source should fail if maintainer is not ubuntu and DEBEMAIL contains @canonical.com

[Łukasz Zemczak]

+1 on getting this into -proposed but not releasing into -updates *for
now*. Thanks for the block-proposed tags!

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to dpkg in Ubuntu.
https://bugs.launchpad.net/bugs/1951988

Title:
  dpkg-source should fail if maintainer is not ubuntu and DEBEMAIL
  contains @canonical.com

Status in dpkg package in Ubuntu:
  Fix Released
Status in dpkg source package in Focal:
  In Progress
Status in dpkg source package in Impish:
  In Progress
Status in dpkg package in Debian:
  New

Bug description:
  [Impact]
  dpkg-source will do a check for a scenario where the maintainer field in d/control does not contain "ubuntu" and the DEBEMAIL environment variable ends in @ubuntu.com. There are some Canonical employees that use an @canonical.com email address instead, so we should expand this check to also trigger on DEBEMAIL values that end in @canonical.com

  [Test Case]
  In a source package that doesn't have XSBC-Original-Maintainer set run
  1) DEBEMAIL=brian at canonical.com debuild -i -I -S -d

  With version of the dpkg in the release pocket you'll receive a
  warning, with the version of the package from -updates you'll instead
  receive an error.

  dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
  dpkg-source: info: using options from sed-4.8/debian/source/options: --single-debian-patch --auto-commit
  dpkg-source: info: using source format '3.0 (quilt)'
  dpkg-buildpackage: error: dpkg-source -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -b . subprocess returned exit status 2
  debuild: fatal error at line 1182:
  dpkg-buildpackage -us -uc -ui -i.pc* -I.bzr -I.svn -ICVS -I.pc -i -I -S -d failed

  [Other Info]
  Having every Ubuntu user update dpkg for a change that'll only benefit Ubuntu developers seems like a bit much. So instead we'll stage this in -proposed and in the event there is an SRU of dpkg or a security update we'll get this included.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/1951988/+subscriptions