[Bug 1914481] Re: use the size of the data when determing the server response

[Brian Murray]

** Description changed:

  whoopsie's server_response code is using "g_string_append" instead of
  "g_string_append_len" which has the knock on effect of sending too much
  data to its "handle_response". This ends up being a problem if the daisy
  servers are running on Ubuntu 18.04 instead of Ubuntu 16.04.
  
  Here's an example when using whoopsie on groovy to send a crash to a
  bionic daisy server:
  
  [15:35:30] Sent; server replied with: No error
  [15:35:30] Response code: 200
  [15:35:30] Initial response data is: 2bbb776e-64e6-11eb-a8d6-00163eddedf4 OOPSID
  0
  
  [15:35:30] Got command: OOPSID
  
  We can see a fair number of extra characters (\n0\n\n) after the OOSID
- command.
+ command. This becomes more problematic when daisy requests a core dump
+ from the client as the CORE command won't match and the client will
+ never send the core dump.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to whoopsie in Ubuntu.
https://bugs.launchpad.net/bugs/1914481

Title:
  use the size of the data when determing the server response

Status in whoopsie package in Ubuntu:
  Fix Released
Status in whoopsie source package in Focal:
  New
Status in whoopsie source package in Groovy:
  New
Status in whoopsie source package in Hirsute:
  Fix Released

Bug description:
  whoopsie's server_response code is using "g_string_append" instead of
  "g_string_append_len" which has the knock on effect of sending too
  much data to its "handle_response". This ends up being a problem if
  the daisy servers are running on Ubuntu 18.04 instead of Ubuntu 16.04.

  Here's an example when using whoopsie on groovy to send a crash to a
  bionic daisy server:

  [15:35:30] Sent; server replied with: No error
  [15:35:30] Response code: 200
  [15:35:30] Initial response data is: 2bbb776e-64e6-11eb-a8d6-00163eddedf4 OOPSID
  0

  [15:35:30] Got command: OOPSID

  We can see a fair number of extra characters (\n0\n\n) after the OOSID
  command. This becomes more problematic when daisy requests a core dump
  from the client as the CORE command won't match and the client will
  never send the core dump.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/whoopsie/+bug/1914481/+subscriptions