[Bug 1900897] Re: Please build the package as upstream does

[Launchpad Bug Tracker]

This bug was fixed in the package google-guest-agent -
20201217.02-0ubuntu1~20.10.0

---------------
google-guest-agent (20201217.02-0ubuntu1~20.10.0) groovy; urgency=medium

  * Backport to Groovy

google-guest-agent (20201217.02-0ubuntu1) hirsute; urgency=medium

  * New upstream release (LP: #1911448)
  * debian/watch: Fix version handing in the download URL
  * Update vendored files

google-guest-agent (20200617.00-0ubuntu8) hirsute; urgency=medium

  * debian/rules: Build the package as preferred by upstream
    - Strip the binary
    - Set main.version (LP: #1900897)
  * Declare Breaks: on python3-google-compute-engine
    to force conscious removal of the Python libraries that are not maintained
    and this package make obsolete. (LP: #1905986)

google-guest-agent (20200617.00-0ubuntu7) hirsute; urgency=medium

  * No-change rebuild using new golang

 -- Balint Reczey <rbalint at ubuntu.com>  Wed, 13 Jan 2021 20:43:31 +0100

** Changed in: google-guest-agent (Ubuntu Groovy)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to google-guest-agent in Ubuntu.
https://bugs.launchpad.net/bugs/1900897

Title:
  Please build the package as upstream does

Status in google-guest-agent package in Ubuntu:
  Fix Released
Status in google-osconfig-agent package in Ubuntu:
  Fix Released
Status in google-guest-agent source package in Groovy:
  Fix Released

Bug description:
  [Impact]

   * Upstream would like Ubuntu packages to use the build options
  closest to upstream's practice.

  [Test Case]

   * Check the build logs if the following options are used (-mod=readonly is not needed because the build does not use go mod):
    -ldflags="-s -w -X main.version=$(shell dpkg-parsechangelog -S Version)"

  [Where problems could occur]

   * The build options just strip the binary and set the current
  version. None of those should cause any problem.

  [Original Bug Text]

  Upstream's build parameters;

  override_dh_auto_build:
         dh_auto_build -O--buildsystem=golang -- -ldflags="-s -w -X main.version=$(VERSION)-$(RELEASE)" -mod=readonly

   - Strip the binary
   - Set main.version

  (Upstream asked for that.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/google-guest-agent/+bug/1900897/+subscriptions