[Bug 1902260] Re: systemd-detect-virt is missing on Groovy EC2 AMI

[Dimitri John Ledkov]

>From https://launchpad.net/~xnox/+livefs/ubuntu/focal/any/+build/259783

downloading the .img (qcow) image

mounting p15 i can see that /ubuntu/ paths now exist, and will be used
for booting via BOOTX64.CSV

 tree /mnt/
/mnt/
└── EFI
    ├── BOOT
    │ ├── BOOTX64.EFI
    │ ├── fbx64.efi
    │ └── mmx64.efi
    └── ubuntu
        ├── BOOTX64.CSV
        ├── grub.cfg
        ├── grubx64.efi
        ├── mmx64.efi
        └── shimx64.efi

3 directories, 8 files

Mounting the p1 partition I can see that fsck will be performed on both
partitions

$ cat /mnt/etc/fstab
LABEL=cloudimg-rootfs / ext4 defaults 0 1
LABEL=UEFI /boot/efi vfat defaults 0 1

$ LD_PRELOAD=/mnt/usr/lib/systemd/libsystemd-shared-245.so /mnt/usr/bin/systemd-detect-virt
none

can be executed and is present (although this image would not have
triggered the bug of missing systemd-detect-virt, this bug would need to
be verified elsewhere)

** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1902260

Title:
  systemd-detect-virt is missing on Groovy EC2 AMI

Status in cloud-images:
  Confirmed
Status in livecd-rootfs package in Ubuntu:
  Fix Released
Status in livecd-rootfs source package in Xenial:
  Fix Committed
Status in livecd-rootfs source package in Bionic:
  Fix Committed
Status in livecd-rootfs source package in Focal:
  Fix Committed
Status in livecd-rootfs source package in Groovy:
  Fix Committed

Bug description:
  [Impact]

   * On some image types, systemd-detect-virt might be missing

  [Test Case]

   * $ sudo systemd-detect-virt

  Should print a word.

  If it prints "no such file or directory" it is buggy.

  Best reproduced on initrdless boot, public cloud, where kernel flavour
  is switched, such as GCP groovy or AWS EC2 groovy. However other image
  types might be affected too.

  Backporting the change to all series, in case there are other places
  which invoke undivert_grub multiple times in a row.

  [Where problems could occur]

   * Hopefully, systemd-detect-virt undivert is now correct. Issues
  might happen in case systemd is not meant to be installed and yet the
  file remains on disk; or if the diversion is not removed still.
  Resulting in incorrect runtime behaviour.

   * For the images where this is fixed, systemd-detect-virt will now
  start working correctly. Thus may trigger automation to run that
  relied on missing systemd-detect-virt and thus previously did not
  execute.

  [Other Info]
   
   * Original bug report

  
  ubuntu/images/hvm-ssd/ubuntu-groovy-20.10-arm64-server-20201022.1

  ubuntu at ip-172-31-30-199:~$ dpkg -S systemd-detect-virt
  systemd: /usr/bin/systemd-detect-virt
  systemd: /usr/share/bash-completion/completions/systemd-detect-virt
  systemd: /usr/share/man/man1/systemd-detect-virt.1.gz
  ubuntu at ip-172-31-30-199:~$ ls /usr/bin/systemd-detect-virt
  ls: cannot access '/usr/bin/systemd-detect-virt': No such file or directory

  Since livecd-rootfs plays with diversions of this file it looks
  suspicious, but I have not fully triaged the problem.

  LXD image for amd64 seems to be ok: ubuntu 20.10 amd64 (release)
  (20201022.1)

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-images/+bug/1902260/+subscriptions