[Bug 1916536] [NEW] increase in SUBBUCKETS has performance impact

[Dan Streetman]

Public bug reported:

[impact]

a negative performance impact is found with the increase in SUBBUCKETS

[test case]

TBD

[regression potential]

any regression would likely cause performance issues

[scope]

this is needed only for golang 1.14 and 1.15; the patch is not added in
1.13 or earlier, nor in 1.16.

Specifically, this is needed in f/g/h in the specific golang versions as
shown:

$ grep -E 'SUBBUCKETS += 32'  */*/golang-*/src/cmd/link/internal/ld/pcln.go
golang-1.14/focal/golang-1.14-1.14.3/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
golang-1.14/groovy/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
golang-1.14/hirsute/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
golang-1.15/hirsute/golang-1.15-1.15.8/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32

[other info]

this was added to golang-1.14 with the patch:
debian/patches/0001-cmd-link-add-support-for-external-linking-on-linux-r.patch
and golong-1.15 with the similar patch:
debian/patches/fc3e6af10297b424175b44d2274de04c5f0b9e82.patch

There does not appear to be any documentation or explanation for why the
patch modifies SUBBUCKETS.

Upstream, this appears to have been done with the commit
15eaa870e14195c17dbb4be0d11bc40dba94ff22, which does not change
SUBBUCKETS.

** Affects: golang-1.14 (Ubuntu)
     Importance: Medium
         Status: New

** Affects: golang-1.15 (Ubuntu)
     Importance: Medium
         Status: New

** Affects: golang-1.14 (Ubuntu Focal)
     Importance: Medium
         Status: New

** Affects: golang-1.15 (Ubuntu Focal)
     Importance: Undecided
         Status: Invalid

** Affects: golang-1.14 (Ubuntu Groovy)
     Importance: Medium
         Status: New

** Affects: golang-1.15 (Ubuntu Groovy)
     Importance: Undecided
         Status: Invalid

** Affects: golang-1.14 (Ubuntu Hirsute)
     Importance: Medium
         Status: New

** Affects: golang-1.15 (Ubuntu Hirsute)
     Importance: Medium
         Status: New

** Also affects: golang-1.14 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: golang-1.14 (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: golang-1.15 (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: golang-1.14 (Ubuntu Hirsute)
   Importance: Undecided
       Status: New

** Also affects: golang-1.15 (Ubuntu Hirsute)
   Importance: Undecided
       Status: New

** Also affects: golang-1.14 (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Also affects: golang-1.15 (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Changed in: golang-1.15 (Ubuntu Focal)
       Status: New => Invalid

** Changed in: golang-1.15 (Ubuntu Groovy)
       Status: New => Invalid

** Changed in: golang-1.15 (Ubuntu Hirsute)
   Importance: Undecided => Medium

** Changed in: golang-1.14 (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: golang-1.14 (Ubuntu Groovy)
   Importance: Undecided => Medium

** Changed in: golang-1.14 (Ubuntu Hirsute)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to golang-1.15 in Ubuntu.
https://bugs.launchpad.net/bugs/1916536

Title:
  increase in SUBBUCKETS has performance impact

Status in golang-1.14 package in Ubuntu:
  New
Status in golang-1.15 package in Ubuntu:
  New
Status in golang-1.14 source package in Focal:
  New
Status in golang-1.15 source package in Focal:
  Invalid
Status in golang-1.14 source package in Groovy:
  New
Status in golang-1.15 source package in Groovy:
  Invalid
Status in golang-1.14 source package in Hirsute:
  New
Status in golang-1.15 source package in Hirsute:
  New

Bug description:
  [impact]

  a negative performance impact is found with the increase in SUBBUCKETS

  [test case]

  TBD

  [regression potential]

  any regression would likely cause performance issues

  [scope]

  this is needed only for golang 1.14 and 1.15; the patch is not added
  in 1.13 or earlier, nor in 1.16.

  Specifically, this is needed in f/g/h in the specific golang versions
  as shown:

  $ grep -E 'SUBBUCKETS += 32'  */*/golang-*/src/cmd/link/internal/ld/pcln.go
  golang-1.14/focal/golang-1.14-1.14.3/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
  golang-1.14/groovy/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
  golang-1.14/hirsute/golang-1.14-1.14.7/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32
  golang-1.15/hirsute/golang-1.15-1.15.8/src/cmd/link/internal/ld/pcln.go:	SUBBUCKETS    = 32

  [other info]

  this was added to golang-1.14 with the patch:
  debian/patches/0001-cmd-link-add-support-for-external-linking-on-linux-r.patch
  and golong-1.15 with the similar patch:
  debian/patches/fc3e6af10297b424175b44d2274de04c5f0b9e82.patch

  There does not appear to be any documentation or explanation for why
  the patch modifies SUBBUCKETS.

  Upstream, this appears to have been done with the commit
  15eaa870e14195c17dbb4be0d11bc40dba94ff22, which does not change
  SUBBUCKETS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-1.14/+bug/1916536/+subscriptions