[Bug 1898026] Re: interruption of dist-upgrade can leave you next release in sources.list

[Brian Murray]

While a KeyboardInterrupt handler has been introduced to ubuntu-release-
upgrader apt is actually sending the SIGINT back to the distribution
upgrade process. This can be fixed in apt by removing the following:

--- apt-2.1.10ubuntu0.2/apt-pkg/contrib/fileutl.cc      2021-01-14 03:29:25.000000000 -0800
+++ apt-2.1.10ubuntu0.3~ppa1/apt-pkg/contrib/fileutl.cc 2021-02-26 09:13:10.000000000 -0800
@@ -140,10 +140,6 @@
       return _error->Errno("waitpid","Couldn't wait for subprocess");
    }
 
-   // Restore sig int/quit
-   signal(SIGQUIT,SIG_DFL);
-   signal(SIGINT,SIG_DFL);   
-
    // Check for an error code.
    if (WIFEXITED(Status) == 0 || WEXITSTATUS(Status) != 0)
    {


** Also affects: apt (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: apt (Ubuntu Hirsute)
   Importance: Undecided => High

** Changed in: apt (Ubuntu Hirsute)
       Status: New => Triaged

** Changed in: apt (Ubuntu Hirsute)
     Assignee: (unassigned) => Julian Andres Klode (juliank)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1898026

Title:
  interruption of dist-upgrade can leave you next release in
  sources.list

Status in apt package in Ubuntu:
  Triaged
Status in ubuntu-release-upgrader package in Ubuntu:
  In Progress
Status in apt source package in Hirsute:
  Triaged
Status in ubuntu-release-upgrader source package in Hirsute:
  In Progress

Bug description:
  As a long-time-user of ?ubuntu, with apt-get as tool of choice for updates/upgrades I wrote a daily script for updates, with 'dist-upgrade'. 
  In all earlier years, it wouldn't actually do an upgrade of a ?ubuntu version; just all packages including new ones. Version updates had to be initiated manually, and I was always asked if I really wanted the new ?ubuntu version. Sounds appropriate.

  Last night when it (dist-upgrade), it just gave me 20.04. No questions asked. I for one consider this kind of intrusive, though. 
  It *might* have to make with me trying 'sudo do-release-upgrade -m desktop' a number of times earlier; just to *check* if the upgrade was on offer; but this is only a guess.

  In *any* case, a pop-up asking "Are you sure? Are you connected
  through an adequate pipe? Are you sitting with full batteries; better
  a power supply?" would be convenient; since I am using my PC for
  urgent duties, and didn't want to fiddle with unexpected upgrade bugs.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: ubuntu-release-upgrader-core 1:20.04.25
  ProcVersionSignature: Ubuntu 5.4.0-48.52-generic 5.4.60
  Uname: Linux 5.4.0-48-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27.9
  Architecture: amd64
  CasperMD5CheckResult: skip
  CrashDB: ubuntu
  CurrentDesktop: KDE
  Date: Thu Oct  1 11:48:39 2020
  InstallationDate: Installed on 2019-03-14 (566 days ago)
  InstallationMedia: Kubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180725)
  PackageArchitecture: all
  SourcePackage: ubuntu-release-upgrader
  Symptom: ubuntu-release-upgrader
  UpgradeStatus: Upgraded to focal on 2020-09-29 (1 days ago)
  VarLogDistupgradeAptlog:
   Log time: 2020-09-29 19:44:28.696289
   Log time: 2020-09-29 19:44:33.573481

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1898026/+subscriptions