[Bug 1913601] [NEW] add-apt-repository does not correctly enable sources

[Dan Streetman]

Public bug reported:

[impact]

'add-apt-repository -s' should enable deb-src for all existing repos,
but doesn't

[test case]

root at sp-g:~# add-apt-repository -sL
deb http://archive.ubuntu.com/ubuntu groovy restricted universe multiverse main
deb http://archive.ubuntu.com/ubuntu groovy-updates restricted universe multiverse main
deb http://archive.ubuntu.com/ubuntu groovy-backports restricted universe multiverse main
deb http://security.ubuntu.com/ubuntu groovy-security restricted universe multiverse main
root at sp-g:~# add-apt-repository -s
Enabling deb-src for all repositories.
Press [ENTER] to continue or Ctrl-c to cancel.
Enabled: None
Enabled: None
Enabled: deb-src http://archive.ubuntu.com/ubuntu groovy-backports multiverse universe restricted main
Enabled: deb-src http://archive.canonical.com/ubuntu groovy partner
Enabled: None
Hit:1 http://security.ubuntu.com/ubuntu groovy-security InRelease
Get:2 http://security.ubuntu.com/ubuntu groovy-security/universe Sources [6608 B]
Hit:3 http://archive.ubuntu.com/ubuntu groovy InRelease                     
Hit:4 http://archive.ubuntu.com/ubuntu groovy-updates InRelease             
Hit:5 http://archive.ubuntu.com/ubuntu groovy-backports InRelease
Get:6 http://archive.ubuntu.com/ubuntu groovy/multiverse Sources [279 kB]
Get:7 http://archive.ubuntu.com/ubuntu groovy/universe Sources [16.3 MB]
Get:8 http://archive.canonical.com/ubuntu groovy InRelease [11.4 kB]        
Get:9 http://archive.ubuntu.com/ubuntu groovy-updates/multiverse Sources [3124 B]
Get:10 http://archive.ubuntu.com/ubuntu groovy-updates/universe Sources [19.0 kB]
Get:11 http://archive.ubuntu.com/ubuntu groovy-backports/universe Sources [2004 B]         
Get:12 http://archive.canonical.com/ubuntu groovy/partner Sources [720 B]                
Fetched 16.6 MB in 6s (2884 kB/s)                      
Reading package lists... Done
root at sp-g:~# add-apt-repository -sL
deb http://archive.ubuntu.com/ubuntu groovy multiverse restricted main universe
deb-src http://archive.ubuntu.com/ubuntu groovy multiverse universe
deb http://archive.ubuntu.com/ubuntu groovy-updates multiverse restricted main universe
deb-src http://archive.ubuntu.com/ubuntu groovy-updates multiverse universe
deb http://archive.ubuntu.com/ubuntu groovy-backports multiverse restricted main universe
deb-src http://archive.ubuntu.com/ubuntu groovy-backports multiverse restricted main universe
deb-src http://archive.canonical.com/ubuntu groovy partner
deb http://security.ubuntu.com/ubuntu groovy-security multiverse restricted main universe
deb-src http://security.ubuntu.com/ubuntu groovy-security multiverse universe

[regression potential]

any regression would likely cause add-apt-repository to incorrectly
update the apt sources.list and/or sources.list.d file(s), most likely
when modifying the deb-src lines

[scope]

this is needed in g and later

the --enable-source parameter in focal and earlier could only be used
with a specific repo to be modified, so this is not applicable to f or
earlier

** Affects: software-properties (Ubuntu)
     Importance: Medium
     Assignee: Dan Streetman (ddstreet)
         Status: In Progress

** Affects: software-properties (Ubuntu Groovy)
     Importance: Medium
     Assignee: Dan Streetman (ddstreet)
         Status: In Progress

** Affects: software-properties (Ubuntu Hirsute)
     Importance: Medium
     Assignee: Dan Streetman (ddstreet)
         Status: In Progress

** Also affects: software-properties (Ubuntu Hirsute)
   Importance: Undecided
       Status: New

** Also affects: software-properties (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Changed in: software-properties (Ubuntu Groovy)
     Assignee: (unassigned) => Dan Streetman (ddstreet)

** Changed in: software-properties (Ubuntu Hirsute)
     Assignee: (unassigned) => Dan Streetman (ddstreet)

** Changed in: software-properties (Ubuntu Hirsute)
   Importance: Undecided => Medium

** Changed in: software-properties (Ubuntu Groovy)
   Importance: Undecided => Medium

** Changed in: software-properties (Ubuntu Hirsute)
       Status: New => In Progress

** Changed in: software-properties (Ubuntu Groovy)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1913601

Title:
  add-apt-repository does not correctly enable sources

Status in software-properties package in Ubuntu:
  In Progress
Status in software-properties source package in Groovy:
  In Progress
Status in software-properties source package in Hirsute:
  In Progress

Bug description:
  [impact]

  'add-apt-repository -s' should enable deb-src for all existing repos,
  but doesn't

  [test case]

  root at sp-g:~# add-apt-repository -sL
  deb http://archive.ubuntu.com/ubuntu groovy restricted universe multiverse main
  deb http://archive.ubuntu.com/ubuntu groovy-updates restricted universe multiverse main
  deb http://archive.ubuntu.com/ubuntu groovy-backports restricted universe multiverse main
  deb http://security.ubuntu.com/ubuntu groovy-security restricted universe multiverse main
  root at sp-g:~# add-apt-repository -s
  Enabling deb-src for all repositories.
  Press [ENTER] to continue or Ctrl-c to cancel.
  Enabled: None
  Enabled: None
  Enabled: deb-src http://archive.ubuntu.com/ubuntu groovy-backports multiverse universe restricted main
  Enabled: deb-src http://archive.canonical.com/ubuntu groovy partner
  Enabled: None
  Hit:1 http://security.ubuntu.com/ubuntu groovy-security InRelease
  Get:2 http://security.ubuntu.com/ubuntu groovy-security/universe Sources [6608 B]
  Hit:3 http://archive.ubuntu.com/ubuntu groovy InRelease                     
  Hit:4 http://archive.ubuntu.com/ubuntu groovy-updates InRelease             
  Hit:5 http://archive.ubuntu.com/ubuntu groovy-backports InRelease
  Get:6 http://archive.ubuntu.com/ubuntu groovy/multiverse Sources [279 kB]
  Get:7 http://archive.ubuntu.com/ubuntu groovy/universe Sources [16.3 MB]
  Get:8 http://archive.canonical.com/ubuntu groovy InRelease [11.4 kB]        
  Get:9 http://archive.ubuntu.com/ubuntu groovy-updates/multiverse Sources [3124 B]
  Get:10 http://archive.ubuntu.com/ubuntu groovy-updates/universe Sources [19.0 kB]
  Get:11 http://archive.ubuntu.com/ubuntu groovy-backports/universe Sources [2004 B]         
  Get:12 http://archive.canonical.com/ubuntu groovy/partner Sources [720 B]                
  Fetched 16.6 MB in 6s (2884 kB/s)                      
  Reading package lists... Done
  root at sp-g:~# add-apt-repository -sL
  deb http://archive.ubuntu.com/ubuntu groovy multiverse restricted main universe
  deb-src http://archive.ubuntu.com/ubuntu groovy multiverse universe
  deb http://archive.ubuntu.com/ubuntu groovy-updates multiverse restricted main universe
  deb-src http://archive.ubuntu.com/ubuntu groovy-updates multiverse universe
  deb http://archive.ubuntu.com/ubuntu groovy-backports multiverse restricted main universe
  deb-src http://archive.ubuntu.com/ubuntu groovy-backports multiverse restricted main universe
  deb-src http://archive.canonical.com/ubuntu groovy partner
  deb http://security.ubuntu.com/ubuntu groovy-security multiverse restricted main universe
  deb-src http://security.ubuntu.com/ubuntu groovy-security multiverse universe

  [regression potential]

  any regression would likely cause add-apt-repository to incorrectly
  update the apt sources.list and/or sources.list.d file(s), most likely
  when modifying the deb-src lines

  [scope]

  this is needed in g and later

  the --enable-source parameter in focal and earlier could only be used
  with a specific repo to be modified, so this is not applicable to f or
  earlier

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1913601/+subscriptions