[Bug 1929560] Re: link mac isn't set if already up

[Brian Murray]

Hello Dan, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.7 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: systemd (Ubuntu Focal)
       Status: In Progress => Fix Committed

** Tags added: verification-needed-focal

** Changed in: systemd (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1929560

Title:
  link mac isn't set if already up

Status in systemd:
  Fix Released
Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Bionic:
  Fix Committed
Status in systemd source package in Focal:
  Fix Committed
Status in systemd source package in Groovy:
  Fix Committed

Bug description:
  [impact]

  if link is already up, configured mac isn't set

  this also affects the master/nomaster configuration

  [test case]

  create .network config for the link, for example:

  [Match]
  Name=eth0

  [Link]
  MACAddress=00:16:3e:ff:ff:ff

  [Network]
  DHCP=yes

  
  make sure the link is already up, and restart systemd-networkd:

  root at test-f:/etc/systemd/network# ip l show eth0
  61: eth0 at if62: <BROADCAST,MULTICAST> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
      link/ether 00:16:3e:fc:b2:00 brd ff:ff:ff:ff:ff:ff link-netnsid 0
  root at test-f:/etc/systemd/network# ip l set dev eth0 up
  root at test-f:/etc/systemd/network# ip l show eth0
  61: eth0 at if62: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
      link/ether 00:16:3e:fc:b2:00 brd ff:ff:ff:ff:ff:ff link-netnsid 0
  root at test-f:/etc/systemd/network# systemctl restart systemd-networkd
  root at test-f:/etc/systemd/network# ip l show eth0
  61: eth0 at if62: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
      link/ether 00:16:3e:fc:b2:00 brd ff:ff:ff:ff:ff:ff link-netnsid 0
  root at test-f:/etc/systemd/network# ip l set dev eth0 down
  root at test-f:/etc/systemd/network# ip l show eth0
  61: eth0 at if62: <BROADCAST,MULTICAST> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default qlen 1000
      link/ether 00:16:3e:fc:b2:00 brd ff:ff:ff:ff:ff:ff link-netnsid 0
  root at test-f:/etc/systemd/network# systemctl restart systemd-networkd
  root at test-f:/etc/systemd/network# ip l show eth0
  61: eth0 at if62: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
      link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff link-netnsid 0

  [regression potential]

  any regression would likely result in incorrectly set link mac and/or
  master, or failure to correctly set mac and/or master

  [scope]

  this is needed for g and earlier

  this is fixed upstream by commit
  e16e4b3bedc57919b3ecb4096e941709a5d39b8a which is included in v247 so
  this is fixed already in h and later

  [other info]

  this moves the configuration of the link mac and master out of the
  link_up() function, so this also allows repeated calls to link_up()
  without reconfiguring the link mac and master. That behavior is useful
  for the commits for bug 1664844

To manage notifications about this bug go to:
https://bugs.launchpad.net/systemd/+bug/1929560/+subscriptions