[Bug 1929849] Re: ftbfs on hirsute due to kernel changing type of RFKILL_EVENT_SIZE_V1

[Dan Streetman]

successfully built on hirsute.

** Tags removed: verification-needed verification-needed-hirsute
** Tags added: verification-done verification-done-hirsute

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1929849

Title:
  ftbfs on hirsute due to kernel changing type of RFKILL_EVENT_SIZE_V1

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Hirsute:
  Fix Committed

Bug description:
  [impact]

  ftbfs

  [test case]

  try to build, e.g.:

  https://launchpadlibrarian.net/540746512/buildlog_ubuntu-hirsute-
  amd64.systemd_247.3-3ubuntu3.1_BUILDING.txt.gz

  ../src/rfkill/rfkill.c: In function ‘load_state’:
  ../src/rfkill/rfkill.c:180:15: warning: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
    180 |         if (l < RFKILL_EVENT_SIZE_V1)

  [regression potential]

  any regression would likely cause ftbfs or could cause improper
  reading/parsing of the kernel rfkill data

  [scope]

  this is needed only for h

  this is fixed upstream in systemd by commit ab1aa6368a8 which was
  pulled into i already.

  this does not exist for g or earlier, as the upstream kernel commit
  71826654ce401 changed the macro value and introduced this problem, and
  that was first included in kernel v5.12 and then backported into
  hirsute v5.11 kernel in commit a8c36c7222055 which was first included
  in Ubuntu-5.11.0-18.19

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1929849/+subscriptions