[Bug 1931112] [NEW] Apple vendor quirk check for LP#1928434 incorrectly fails on all non-DMI hardware

[Alyssa Rowan]

Public bug reported:

v 1:20.10.16

DistUpgradeQuirks.py, in _test_and_fail_on_apple fails if
_readDMIVendor() returns null i.e. if /sys/class/dmi/id/sys_vendor is
unknown.

However, this is a very common case - it means almost all non-x86
hardware and many VMs (including my test case, WSL2 20.10 -> 21.04)
cannot at the time of writing currently upgrade to 21.04.

This was noted in "Where problems could occur" on
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-
upgrader/+bug/1929449 where the root cause of this bug was introduced,
but seems to have been an intentional emergency 'safe' choice while the
shim bug is fixed.

This emergency patch has been in place for 2 weeks now, blocking
updates, however the shim-signed bug appears to be fixed now but the
quirk is still in place - perhaps the "system vendor is unknown" check
should be removed for now, and once verified the quirk removed
altogether?

** Affects: ubuntu-release-upgrader (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "Patch to remove the "unknown vendor" part of the Apple quirk for now which affects non-Apple hardware, while SRE verifies the shim issue is fixed with Apple hardware"
   https://bugs.launchpad.net/bugs/1931112/+attachment/5502933/+files/duq-dmiunknown.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1931112

Title:
  Apple vendor quirk check for LP#1928434 incorrectly fails on all non-
  DMI hardware

Status in ubuntu-release-upgrader package in Ubuntu:
  New

Bug description:
  v 1:20.10.16

  DistUpgradeQuirks.py, in _test_and_fail_on_apple fails if
  _readDMIVendor() returns null i.e. if /sys/class/dmi/id/sys_vendor is
  unknown.

  However, this is a very common case - it means almost all non-x86
  hardware and many VMs (including my test case, WSL2 20.10 -> 21.04)
  cannot at the time of writing currently upgrade to 21.04.

  This was noted in "Where problems could occur" on
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-
  upgrader/+bug/1929449 where the root cause of this bug was introduced,
  but seems to have been an intentional emergency 'safe' choice while
  the shim bug is fixed.

  This emergency patch has been in place for 2 weeks now, blocking
  updates, however the shim-signed bug appears to be fixed now but the
  quirk is still in place - perhaps the "system vendor is unknown" check
  should be removed for now, and once verified the quirk removed
  altogether?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1931112/+subscriptions