[Bug 1930741] Re: 20apt-esm-hook.conf is missing semicolons at end of option

[Julian Andres Klode]

ubuntu-advantage-tools has incorrect syntax in its apt.conf.d snippet;
missing the semicolon at the end of the options for the new options
introduced recently:

APT::Install::Pre-Invoke {
        "[ ! -f /usr/lib/ubuntu-advantage/apt-esm-hook ] || /usr/lib/ubuntu-advantage/apt-esm-hook pre-invoke || true";
}

AptCli::Hooks::Upgrade {
        "[ ! -f /usr/lib/ubuntu-advantage/apt-esm-json-hook ] || /usr/lib/ubuntu-advantage/apt-esm-json-hook || true";
}


This causes aptdaemon's parser to stumble over it; while apt's is too badly written to notice :)

** Summary changed:

- autopkgtest failures on all (most?) releases
+ 20apt-esm-hook.conf is missing semicolons at end of option

** Package changed: aptdaemon (Ubuntu) => ubuntu-advantage-tools
(Ubuntu)

** Changed in: ubuntu-advantage-tools (Ubuntu)
       Status: New => Triaged

** Changed in: ubuntu-advantage-tools (Ubuntu)
   Importance: Undecided => Critical

** Also affects: ubuntu-advantage-tools (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Hirsute)
   Importance: Undecided
       Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Impish)
   Importance: Critical
       Status: Triaged

** Also affects: ubuntu-advantage-tools (Ubuntu Bionic)
   Importance: Undecided
       Status: New

** Also affects: ubuntu-advantage-tools (Ubuntu Xenial)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to aptdaemon in Ubuntu.
https://bugs.launchpad.net/bugs/1930741

Title:
  20apt-esm-hook.conf is missing semicolons at end of option

Status in ubuntu-advantage-tools package in Ubuntu:
  Triaged
Status in ubuntu-advantage-tools source package in Xenial:
  New
Status in ubuntu-advantage-tools source package in Bionic:
  New
Status in ubuntu-advantage-tools source package in Focal:
  New
Status in ubuntu-advantage-tools source package in Groovy:
  New
Status in ubuntu-advantage-tools source package in Hirsute:
  New
Status in ubuntu-advantage-tools source package in Impish:
  Triaged

Bug description:
  Recently aptdaemon started having autopkgtest failures with its
  tests.test_configparser.ConfigurationParserTestCase test. The failure
  follows:

  Test if credentials of repositories are store securely in a ... ok

  ======================================================================
  ERROR: test_ (tests.test_configparser.ConfigurationParserTestCase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/tmp/autopkgtest.cp3vHc/build.adU/src/tests/test_configparser.py", line 82, in test_
      config[key.lower()]]
  KeyError: 'apt::install::pre-invoke'

  ----------------------------------------------------------------------
  Ran 79 tests in 109.732s

  FAILED (errors=1, skipped=21)
  Test failed: <unittest.runner.TextTestResult run=79 errors=1 failures=0>
  error: Test failed: <unittest.runner.TextTestResult run=79 errors=1 failures=0>

  The "APT::Install::Pre-Invoke" key is provided by /etc/apt/apt.conf.d
  /20apt-esm-hook.conf which is from ubuntu-advantage-tools, so I'd
  guess this started happening when it moved to -updates (on 20210513).
  This would also explain why it is affecting every release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1930741/+subscriptions