[Bug 1926660] Re: autopkgtests fail due to new update-motd snippet

[Christian Ehrhardt ]

I can confirm that as of now it runs fine against
- impish
- impish + UA from proposed
- imposh proposed


The test installs all users of update-motd

It does not list ubuntu-advantage-tools but since they are in the image
one would think that it still would be there.

The test intention is:
1. run update-motd while ALL motd scripts installed
2. ensure all are installed

---

To do so for #1 it has the above mentioned dependencies and then runs "update-motd".
This works fine.

---

#2 is checked via "apt-file" to deliver ALL that exist in the archive
And then followed by a check if all those are present on the current system.

The former advantage-tools 26.2 had no motd scripts.
The new 27.0.1 has two:
root at h:~# dpkg -L ubuntu-advantage-tools | grep motd
/etc/update-motd.d
/etc/update-motd.d/88-esm-announce
/etc/update-motd.d/91-contract-ua-esm-status

Those two are correctly reported in the "apt-file" output of impish.

root at h:~# apt-file search /etc/update-motd.d   | grep adv
ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce
ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status


But, since the test runs on "autopkgtest image + new package install" but NOT "apt upgrade" it isn't really testing with 27.0.1.


Most of us usually run autopkgtest with -U|--apt-upgrade and therefore we couldn't reproduce.
But with the following it does show up in a local test:

$ sudo ~/work/autopkgtest/autopkgtest/runner/autopkgtest --no-built-binaries --apt-pocket=proposed=src:ubuntu-advantage-tools --shell-fail update-motd_3.7.dsc -- qemu --ram-size=1536 --cpus 2 ~/work/autopkgtest-impish-amd64.img
...
ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status: /etc/update-motd.d/91-contract-ua-esm-status

This is how the broken testbed looks like:
ubuntu at autopkgtest:~$ apt-cache policy ubuntu-advantage-tools
ubuntu-advantage-tools:
  Installed: 26.2
  Candidate: 27.0.1
  Version table:
     27.0.1 995
        500 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 Packages
 *** 26.2 990
        990 http://archive.ubuntu.com/ubuntu impish/main amd64 Packages
        100 /var/lib/dpkg/status

Options that come to mind
a) change update-motd d/t/control to install ubuntu-advantage-tools which will update it
   => does not work, it is considered already there and not upgraded
What is left is
b) wait until an image is re-spun (not this will also affect all SRUed releases at some point)
c) change update-motd d/t/update-motd to call a full "apt upgrade -y" before the test

(c) does not seems super charming to SRU as test-only fix :-/
I wonder if it would be painful but better to get the images respinned fast as - after all - it is a false positive that will go away.

** Changed in: ubuntu-advantage-tools (Ubuntu)
       Status: New => Invalid

** Changed in: update-motd (Ubuntu)
       Status: New => Triaged

** Changed in: update-motd (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-motd in Ubuntu.
https://bugs.launchpad.net/bugs/1926660

Title:
  autopkgtests fail due to new update-motd snippet

Status in ubuntu-advantage-tools package in Ubuntu:
  Invalid
Status in update-motd package in Ubuntu:
  Triaged

Bug description:
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status: /etc/update-motd.d/91-contract-ua-esm-status
  autopkgtest [09:35:08]: test update-motd: -----------------------]
  autopkgtest [09:35:08]: test update-motd:  - - - - - - - - - - results - - - - - - - - - -
  update-motd          FAIL stderr: ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  autopkgtest [09:35:08]: test update-motd:  - - - - - - - - - - stderr - - - - - - - - - -
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status: /etc/update-motd.d/91-contract-ua-esm-status

  This output is produced by debian/tests/update-motd.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1926660/+subscriptions