[Bug 1926660] Re: autopkgtests fail due to new update-motd snippet

[Balint Reczey]

@paelzer I've uploaded update-motd adding ubuntu-advantage-tools as a
test dependency, because it is accidental that it is already installed
on test images.

The apt-file check is not ideal, because it lists packages which are in -proposed but pinning does not allow them to be installed. As a mitigation I've retried all affected tests with ubuntu-advantage-tools also added as a trigger. The apt-file results could be filtered by taking pinning 
into consideration, but this would not be perfect easily either, thus I think it is not worth it.

Yes, SRU-ing a test-only fix is not ideal either. The tests are there to
ensure that update-motd scripts can be run as a normal user which is
done on WSL: https://balintreczey.hu/blog/introducing-show-motd-message-
of-the-day-for-wsl-and-container-shells/ . An alternative of testing
every script by update-motd would be generating similar tests for every
package shipping and update-motd script.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-motd in Ubuntu.
https://bugs.launchpad.net/bugs/1926660

Title:
  autopkgtests fail due to new update-motd snippet

Status in update-motd package in Ubuntu:
  Triaged

Bug description:
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status: /etc/update-motd.d/91-contract-ua-esm-status
  autopkgtest [09:35:08]: test update-motd: -----------------------]
  autopkgtest [09:35:08]: test update-motd:  - - - - - - - - - - results - - - - - - - - - -
  update-motd          FAIL stderr: ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  autopkgtest [09:35:08]: test update-motd:  - - - - - - - - - - stderr - - - - - - - - - -
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/88-esm-announce: /etc/update-motd.d/88-esm-announce
  ERROR: Untested update-motd snippet: ubuntu-advantage-tools: /etc/update-motd.d/91-contract-ua-esm-status: /etc/update-motd.d/91-contract-ua-esm-status

  This output is produced by debian/tests/update-motd.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-motd/+bug/1926660/+subscriptions