[Bug 1926990] Re: update-notifier should not alert users about esm-apps in a ESM machine

Fri May 21 03:33:59 UTC 2021

** Description changed:

  [Impact]
- When users are running an ESM distro and looking at motd message they may be trigger by an alert generated by update-notifier that both esm-infra and esm-apps could be enable in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that
- users will be receiving alerts for esm-apps that are not necessary
- 
+ When users are running an ESM distro and looking at the motd message they may be triggered by an alert generated by update-notifier that both esm-infra and esm-apps could be enabled in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that users will be receiving alerts for esm-apps that are not necessary.

  [Test case]

  To reproduce the issue, you can:

  1. Launch a xenial container
  2. create the file /etc/ubuntu-advantage/uaclient.conf with the following content:

  # Ubuntu-Advantage client config file.
  contract_url: 'https://contracts.canonical.com'
  security_url: 'https://ubuntu.com/security'
  data_dir: /var/lib/ubuntu-advantage
  log_level: debug
  log_file: /var/log/ubuntu-advantage.log
  features:
-   allow_beta: true
+   allow_beta: true

  3. install ubuntu-advantage-client from this ppa:
  https://code.launchpad.net/~ua-client/+archive/ubuntu/daily

  PS: Make sure to not allow the installation to override the config file
  you have just created.

  4. Update the version of update-notifier to the one in proposed
  5. Run `/usr/lib/update-notifier/apt-check --human-readable`
  6. Verify that both esm-infra and esm-apps alerts appear in the end of the message

  To verify that the error is fixed:

  1. Run the past scenario until step 3
  2. Install the new update-notifier from this ppa:
  https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/
  3. Run `/usr/lib/update-notifier/apt-check --human-readable`
  4. Verify that only esm-infra is now showing an alert message at the end

  [Where problems could occur]

  We are only changing here the condition to output esm-apps alerts. If that condition is not right we may miss to display those messages to users that
  need them.

  [Discussion]
  When running /usr/lib/update-notifier/apt-check on a ESM machine, we could alert the user about the existence of both esm-infra and esm-apps if the system has unauthenticated source file for both services. Therefore, we would display a message like that in the system:

  --------------------------
  Enable UA Apps: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status

  Enable UA Infra: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status
  ----------------------------------

  This is not ideal, since ESM machine will not gain much from esm-apps.
  Also, this messaging may hide the importance of using esm-infra on ESM
  machines, since the users will not know beforehand which service to
  prioritize.

  == Changelog ==

-   * data/apt_check.py
-     - do not show esm-apps alerts on esm distros
+   * data/apt_check.py
+     - do not show esm-apps alerts on esm distros

** Description changed:

  [Impact]
- When users are running an ESM distro and looking at the motd message they may be triggered by an alert generated by update-notifier that both esm-infra and esm-apps could be enabled in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that users will be receiving alerts for esm-apps that are not necessary.
+ When users are running an ESM distro and looking at the MOTD they may be surprised by an alert generated by update-notifier that both esm-infra and esm-apps could be enabled in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that users will be receiving alerts about esm-apps unnecessarily.

  [Test case]

- To reproduce the issue, you can:
+ To reproduce the issue:

  1. Launch a xenial container
- 2. create the file /etc/ubuntu-advantage/uaclient.conf with the following content:
+ 2. Create the file /etc/ubuntu-advantage/uaclient.conf with the following content:

  # Ubuntu-Advantage client config file.
  contract_url: 'https://contracts.canonical.com'
  security_url: 'https://ubuntu.com/security'
  data_dir: /var/lib/ubuntu-advantage
  log_level: debug
  log_file: /var/log/ubuntu-advantage.log
  features:
    allow_beta: true

- 3. install ubuntu-advantage-client from this ppa:
+ 3. Install ubuntu-advantage-client from this PPA:
  https://code.launchpad.net/~ua-client/+archive/ubuntu/daily

  PS: Make sure to not allow the installation to override the config file
  you have just created.

  4. Update the version of update-notifier to the one in proposed
  5. Run `/usr/lib/update-notifier/apt-check --human-readable`
- 6. Verify that both esm-infra and esm-apps alerts appear in the end of the message
+ 6. Verify that both esm-infra and esm-apps alerts appear at the end of the message

  To verify that the error is fixed:

  1. Run the past scenario until step 3
  2. Install the new update-notifier from this ppa:
  https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/
  3. Run `/usr/lib/update-notifier/apt-check --human-readable`
  4. Verify that only esm-infra is now showing an alert message at the end

  [Where problems could occur]

- We are only changing here the condition to output esm-apps alerts. If that condition is not right we may miss to display those messages to users that
- need them.
+ We are only changing the condition for when to output esm-apps alerts.
+ If that condition is not right, we may miss displaying the messages to
+ users that need them.

  [Discussion]
- When running /usr/lib/update-notifier/apt-check on a ESM machine, we could alert the user about the existence of both esm-infra and esm-apps if the system has unauthenticated source file for both services. Therefore, we would display a message like that in the system:
+ When running /usr/lib/update-notifier/apt-check on a ESM machine, we could alert the user about the existence of both esm-infra and esm-apps if the system has unauthenticated source files for both services. Therefore, we would display a message like this in the system:

  --------------------------
  Enable UA Apps: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status

  Enable UA Infra: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status
  ----------------------------------

- This is not ideal, since ESM machine will not gain much from esm-apps.
+ This is not ideal, since ESM machines will not gain much from esm-apps.
  Also, this messaging may hide the importance of using esm-infra on ESM
  machines, since the users will not know beforehand which service to
  prioritize.

  == Changelog ==

    * data/apt_check.py
      - do not show esm-apps alerts on esm distros

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1926990

Title:
  update-notifier should not alert users about esm-apps in a ESM machine

Status in update-notifier package in Ubuntu:
  Fix Released
Status in update-notifier source package in Xenial:
  New
Status in update-notifier source package in Bionic:
  New
Status in update-notifier source package in Focal:
  New

Bug description:
  [Impact]
  When users are running an ESM distro and looking at the MOTD they may be surprised by an alert generated by update-notifier that both esm-infra and esm-apps could be enabled in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that users will be receiving alerts about esm-apps unnecessarily.

  [Test case]

  To reproduce the issue:

  1. Launch a xenial container
  2. Create the file /etc/ubuntu-advantage/uaclient.conf with the following content:

  # Ubuntu-Advantage client config file.
  contract_url: 'https://contracts.canonical.com'
  security_url: 'https://ubuntu.com/security'
  data_dir: /var/lib/ubuntu-advantage
  log_level: debug
  log_file: /var/log/ubuntu-advantage.log
  features:
    allow_beta: true

  3. Install ubuntu-advantage-client from this PPA:
  https://code.launchpad.net/~ua-client/+archive/ubuntu/daily

  PS: Make sure to not allow the installation to override the config
  file you have just created.

  4. Update the version of update-notifier to the one in proposed
  5. Run `/usr/lib/update-notifier/apt-check --human-readable`
  6. Verify that both esm-infra and esm-apps alerts appear at the end of the message

  To verify that the error is fixed:

  1. Run the past scenario until step 3
  2. Install the new update-notifier from this ppa:
  https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/
  3. Run `/usr/lib/update-notifier/apt-check --human-readable`
  4. Verify that only esm-infra is now showing an alert message at the end

  [Where problems could occur]

  We are only changing the condition for when to output esm-apps alerts.
  If that condition is not right, we may miss displaying the messages to
  users that need them.

  [Discussion]
  When running /usr/lib/update-notifier/apt-check on a ESM machine, we could alert the user about the existence of both esm-infra and esm-apps if the system has unauthenticated source files for both services. Therefore, we would display a message like this in the system:

  --------------------------
  Enable UA Apps: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status

  Enable UA Infra: ESM to receive additional future security updates.
  See https://ubuntu.com/security/esm or run: sudo ua status
  ----------------------------------

  This is not ideal, since ESM machines will not gain much from esm-apps.
  Also, this messaging may hide the importance of using esm-infra on ESM
  machines, since the users will not know beforehand which service to
  prioritize.

  == Changelog ==

    * data/apt_check.py
      - do not show esm-apps alerts on esm distros

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926990/+subscriptions