[Bug 1939732] Re: report availability of Ubuntu Advantage ESM services on unattached machines

[Chad Smith]

** Description changed:

+ [Impact]
+ 
+   * Error messages emitted to software-properties-gtk console "[Errno 2] No such file or directory: '/var/lib/ubuntu-advantage/status.json'" due to incorrect expectation that status.json file is written when non-root runs `ua status`
+   * This logic results in multiple `ua status` calls which each result in a network-egress to https://contracts.canonical.com on unattached machines which could result in delays in rendering  the GTK dialogs while awaiting a response.
+ 
+ 
+ [Test Case]
+ 1. Install latest version of Ubuntu advantage from -proposed
+ cat > setup_proposed.sh <<EOF                                                   
+ #/bin/bash                                                                      
+ mirror=http://archive.ubuntu.com/ubuntu                                         
+ echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
+ apt-get update -q                                                               
+ apt-get install -qy software-properties-gtk                                                  
+ EOF                                                                             
+      
+ IP=`uvt-kvm ip ${DESKTOP_VM}`
+ scp setup_proposed.sh ubuntu@$IP:.
+ ssh ubuntu@$IP -- sudo bash ./setup_proposed.sh
+ 
+ 2. run software-properties-gtk on the commandline
+ ssh ubuntu@$IP -- software-properties-gtk
+ 
+ # Validate no error messages on launch
+ 3. Click Updates tab and validate
+ Basic Security Maintenance   "<link>Extend..." opens a browser to ESM
+ 
+ 4. Click Cancel button
+ 
+ 5. Attach to a UA contract and re-run Software and updates UX
+ ssh ubuntu@$IP -- sudo ua attach $MY_TOKEN
+ ssh ubuntu@$IP -- software-properties-gtk
+ # validate no error messages
+ 
+ 6. Click Updates tab and validate:
+ Extended Security Maintenance
+ Active until 12/31/1999
+ 
+ 
+ [Where problems could occur]
+  * invalid parsing of UA contract information or missing /var/lib/ubuntu-advantage/status.json will print messages to the console in the event of errors or warnings.
+  * failures and tracebacks in this code will result in invalid representation of system defaults in the Updates tab about whether or not a machine is attached to a contract or whether the contract is expired.
+  * Other than user-facing documentation about the state of the UA subscription this does not prevent the dialogs from functioning.
+  * limited network environments could have a delay of UX rendering due to `ua status` calls timing out on attempts to reach contracts.canonical.com
+ 
+ 
+ [Original Description]
+ 
  Release: bionic/focal
  Version: 0.96.24.32 (bionic)
  
  Issue:
- Software & Updates GTK UI doesn't report availability of UBuntu Advantage ESM Infra or ESM Apps services on unattached machines
+ Software & Updates GTK UI doesn't report availability of Ubuntu Advantage ESM Infra or ESM Apps services on unattached machines
  
  Steps to repropduce:
  
  Launch software-properties-gtk from the commandline.
  See unexpected errors on the terminal
  
-  No ua status file written:
+  No ua status file written:
  [Errno 2] No such file or directory: '/var/lib/ubuntu-advantage/status.json'
- 
  
  Navigation to the "Updates" tab
  See only:
  Basic Security Maintenance
  04/26/2023
  
  Expected results:
  See no error messages on terminal
  See a link to the right of Basic Security Maintenance on the "Updates" tab that points to ESM info
  Basic Security Maintenance                      Extend...(links to  ubuntu.com/security/esm)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1939732

Title:
  report availability of Ubuntu Advantage ESM services on unattached
  machines

Status in software-properties package in Ubuntu:
  New

Bug description:
  [Impact]

    * Error messages emitted to software-properties-gtk console "[Errno 2] No such file or directory: '/var/lib/ubuntu-advantage/status.json'" due to incorrect expectation that status.json file is written when non-root runs `ua status`
    * This logic results in multiple `ua status` calls which each result in a network-egress to https://contracts.canonical.com on unattached machines which could result in delays in rendering  the GTK dialogs while awaiting a response.

  
  [Test Case]
  1. Install latest version of Ubuntu advantage from -proposed
  cat > setup_proposed.sh <<EOF                                                   
  #/bin/bash                                                                      
  mirror=http://archive.ubuntu.com/ubuntu                                         
  echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
  apt-get update -q                                                               
  apt-get install -qy software-properties-gtk                                                  
  EOF                                                                             
       
  IP=`uvt-kvm ip ${DESKTOP_VM}`
  scp setup_proposed.sh ubuntu@$IP:.
  ssh ubuntu@$IP -- sudo bash ./setup_proposed.sh

  2. run software-properties-gtk on the commandline
  ssh ubuntu@$IP -- software-properties-gtk

  # Validate no error messages on launch
  3. Click Updates tab and validate
  Basic Security Maintenance   "<link>Extend..." opens a browser to ESM

  4. Click Cancel button

  5. Attach to a UA contract and re-run Software and updates UX
  ssh ubuntu@$IP -- sudo ua attach $MY_TOKEN
  ssh ubuntu@$IP -- software-properties-gtk
  # validate no error messages

  6. Click Updates tab and validate:
  Extended Security Maintenance
  Active until 12/31/1999

  
  [Where problems could occur]
   * invalid parsing of UA contract information or missing /var/lib/ubuntu-advantage/status.json will print messages to the console in the event of errors or warnings.
   * failures and tracebacks in this code will result in invalid representation of system defaults in the Updates tab about whether or not a machine is attached to a contract or whether the contract is expired.
   * Other than user-facing documentation about the state of the UA subscription this does not prevent the dialogs from functioning.
   * limited network environments could have a delay of UX rendering due to `ua status` calls timing out on attempts to reach contracts.canonical.com


  [Original Description]

  Release: bionic/focal
  Version: 0.96.24.32 (bionic)

  Issue:
  Software & Updates GTK UI doesn't report availability of Ubuntu Advantage ESM Infra or ESM Apps services on unattached machines

  Steps to repropduce:

  Launch software-properties-gtk from the commandline.
  See unexpected errors on the terminal

   No ua status file written:
  [Errno 2] No such file or directory: '/var/lib/ubuntu-advantage/status.json'

  Navigation to the "Updates" tab
  See only:
  Basic Security Maintenance
  04/26/2023

  Expected results:
  See no error messages on terminal
  See a link to the right of Basic Security Maintenance on the "Updates" tab that points to ESM info
  Basic Security Maintenance                      Extend...(links to  ubuntu.com/security/esm)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1939732/+subscriptions