[Bug 1983996] Re: [MIR] systemd-hwe
Ioanna Alifieraki
1983996 at bugs.launchpad.net
Mon Aug 15 15:57:38 UTC 2022
Review for Package: systemd-hwe
[Summary]
systemd-hwe source package will enable systemd to pull in all of Ubuntu's
hardware-enablement (HWE) hwdb rules.
MIR team ACK.
This does not need a security review.
List of specific binary packages to be promoted to main: systemd-hwe-
hwdb
Notes:
- The package already has a team bug subscriber.
[Duplication]
There is no other package in main providing the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
OK:
- not a go package, no extra constraints to consider in that regard
- No vendoring used, all Built-Using are in main
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency
Problems: None
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: systemd-hwe (Ubuntu)
Status: New => In Progress
** Changed in: systemd-hwe (Ubuntu)
Assignee: Ioanna Alifieraki (joalif) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd-hwe in Ubuntu.
Matching subscriptions: systemd-hwe
https://bugs.launchpad.net/bugs/1983996
Title:
[MIR] systemd-hwe
Status in systemd-hwe package in Ubuntu:
In Progress
Bug description:
[Availability]
- The package systemd-hwe is already in Ubuntu universe.
- The package systemd-hwe builds for the architectures it is designed to work on.
- It currently builds for amd64 and works for all architectures.
- Link to package: https://launchpad.net/ubuntu/+source/systemd-hwe
[Rationale]
- The package systemd-hwe is required in Ubuntu main so that systemd can
Depends:/Recommends: systemd-hwe-hwdb. This will allow systemd to pull in the
full set of Ubuntu's hardware-enablement (HWE) hwdb rules.
- The package systemd-hwe will generally be useful for a large part of
our user base because it is related to HWE.
- The package systemd-hwe is required in Ubuntu main by Kinetic Final Freeze
so that systemd can Depends:/Recommends: systemd-hwe-hwdb in the Kinetic release.
[Security]
- No CVEs/security issues in this software in the past
- no `suid` or `sgid` binaries
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services, timers or recurring jobs
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software
[Quality assurance - function/usage]
- The package works well right after install
[Quality assurance - maintenance]
- The package is maintained well in Ubuntu and has not too many
and long term critical bugs open
- Ubuntu https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug
- The package does not deal with exotic hardware we cannot support
[Quality assurance - testing]
- The package runs a test suite on build time, if it fails
it makes the build fail, link to build log:
https://launchpadlibrarian.net/614269848/buildlog_ubuntu-kinetic-amd64.systemd-hwe_251.2.1_BUILDING.txt.gz
- The package runs an autopkgtest, and is currently passing on
this amd64, arm64, amdhf, s390x, ppc64el list of architectures,
link to test logs: https://autopkgtest.ubuntu.com/packages/systemd-hwe
- The package does have not failing autopkgtests right now
[Quality assurance - packaging]
- debian/watch is not present because it is a native package
- debian/control defines a correct Maintainer field
- This package does not yield massive lintian Warnings, Errors
- Lintian overrides are not present
- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies
- The package will be installed by default, but does not ask debconf
questions higher than medium
- Packaging and build is easy, link to d/rules:
https://git.launchpad.net/~canonical-foundations/+git/systemd-hwe/tree/debian/rules?h=main
[Dependencies]
- No further depends or recommends dependencies that are not yet in main
[Standards compliance]
- This package correctly follows FHS and Debian Policy
[Maintenance/Owner]
- Owning Team will be Foundations
- Team is already subscribed to the package
- This does not use static builds
- This does not use vendored code
- This package is not rust based
- The package has been built in the archive more recently than the last
test rebuild
[Background information]
- The Package description explains the package well
- The project is Ubuntu specific, and its code is hosted here:
https://code.launchpad.net/~canonical-foundations/+git/systemd-hwe/+ref/main
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd-hwe/+bug/1983996/+subscriptions
More information about the foundations-bugs
mailing list