[Bug 1974109] Re: [UBUNTU 22.04] zipl segfaults when "parameters=" is missing

[Łukasz Zemczak]

Hello bugproxy, or anyone else affected,

Accepted s390-tools into jammy-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/s390-tools/2.20.0-0ubuntu3.2 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
jammy to verification-done-jammy. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-jammy. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Tags added: verification-needed verification-needed-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to s390-tools-signed in Ubuntu.
https://bugs.launchpad.net/bugs/1974109

Title:
  [UBUNTU 22.04] zipl segfaults when "parameters=" is missing

Status in Ubuntu on IBM z Systems:
  Fix Committed
Status in s390-tools package in Ubuntu:
  Fix Released
Status in s390-tools-signed package in Ubuntu:
  Fix Released
Status in s390-tools source package in Jammy:
  Fix Committed
Status in s390-tools-signed source package in Jammy:
  Fix Committed
Status in s390-tools source package in Kinetic:
  Fix Released
Status in s390-tools-signed source package in Kinetic:
  Fix Released

Bug description:
  SRU Justification:
  ------------------

  [Impact]

   * The zipl boot-loader tool segfaults if a section doesn't contain
     a "parameters =" line.

   * Adding a "parameters =" line makes the problem go away.

   * This is especially problematic when secure execution is set up,
     since the parameter is provided in the secure image
     and hence a zipl parameter is not needed.

  [Fix]

   * 6ff8202f 6ff8202fa9e172199e995298d336d9dd87ca8180 "zipl: Add
  missing check for a nullpointer."

  [Test Plan]

   * Setup a default Ubuntu Server for s390x test installation.

   * Backup the existing /etc/zipl.conf:
     cp /etc/zipl.conf ~

   * Edit /etc/zipl.conf and remove (or better comment out)
     'the parameters =' line:
     sudo vi /etc/zipl.conf
     and save the file.

   * Execute the zipl tool to re-write the zipl bootloader
     and it will segfault
     without the patch (like this):
     sudo zipl
     Using config file '/etc/zipl.conf'
     Segmentation fault

   * or complete successfully (like this):
     sudo zipl
     Using config file '/etc/zipl.conf'
     Building bootmap in '/boot'
     Adding IPL section 'ubuntu' (default)
     Preparing boot device: dasda (0101).
     Done.

  [Where problems could occur]

   * It's a patch that changes just one line,
     checks the existence of the parmline
     and only then computes it's length,
     and otherwise sets the length to 0.

   * Issues could occur if the compact/short if
     statement is wrong and for example the logic mixed up.

   * Or if somewhere else in the code a length of 0
     for the parameters line is not expected and will
     cause further issues.

   * Both cases can simply be covered by the above test.

  [Other Info]

   * The above fix is included in s390-tools v2.23
     and is with that incl. in the kinetic s390-tools version.
  __________

  ZIPL segfaults if a section doesn't contain a "parameter=" line.
  Adding that line makes the problem go away.

  This is especially a problem when secure execution is set up since the
  parameter is provided in the secure image and hence a zipl parameter
  is not needed.

  ---uname output---
  Linux linux6 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:23 UTC 2022 s390x s390x s390x GNU/Linux

  Machine Type = z16

  ---Steps to Reproduce---
  Add a section to /etc/zipl.conf that doesn't have a parameter line.

  Userspace tool common name: zipl

  The userspace tool has the following bit modes: 64-bit

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974109/+subscriptions