[Bug 1959054] Re: debhelper restarts services marked --no-restart-on-upgrade

[Chad Smith]

Note related bug if a package were to use debhelper-compat 10 vs 9 on
focal.

In Focal, debhelper-compat 10 will incorrectly introduce ignore the
params

        dh_systemd_start --no-restart-on-upgrade --no-start


And will still inject which will restart all services across package upgrade with something like the following pseudo script:
          
deb-systemd-invoke try-restart <all services>

Moral of the story, don't shift your debian/compat version on stable
releases or bad things could happen.

See: LP: #1999159

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to debhelper in Ubuntu.
https://bugs.launchpad.net/bugs/1959054

Title:
  debhelper restarts services marked --no-restart-on-upgrade

Status in debconf package in Ubuntu:
  Fix Released
Status in debhelper package in Ubuntu:
  Fix Released
Status in docker.io package in Ubuntu:
  Fix Released
Status in libvirt package in Ubuntu:
  Fix Released
Status in debconf source package in Jammy:
  Fix Released
Status in debhelper source package in Jammy:
  Fix Released
Status in docker.io source package in Jammy:
  Fix Released
Status in libvirt source package in Jammy:
  Fix Released
Status in debconf package in Debian:
  Fix Released
Status in debhelper package in Debian:
  Fix Released

Bug description:
  Debian bug #994204 (https://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=994204) describes a flaw in debhelper that
  results in the postinst being generated in such a fashion that
  services marked --no-stop-on-upgrade (or its deprecated alias --no-
  restart-on-upgrade), restart anyway.

  Please note: this is nothing to do with the --no-restart-after-upgrade
  flag (which is, somewhat confusingly IMO, unrelated).

  I've confirmed that the flaw appears to be present in the jammy
  version of debhelper (though not impish) and that packages generated
  with it appear to contain the flawed postinst (I first encountered
  this whilst working on the open-iscsi merge), though I haven't yet
  managed to test that the flaw exhibits itself on upgrade (though I'd
  say from the presence of the flaw in the postinst, that it's a
  reasonable inference that it will).

  In dbus (the merge of which I'm currently working on), Debian has
  worked around this but given I've now run into two affected packages
  (open-iscsi and dbus), only one of which has a work-around, I'd much
  rather we got debhelper fixed up and rebuilt affected packages?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debconf/+bug/1959054/+subscriptions