[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown

[Dan Bungert]

** Description changed:

+ [Impact]
  On a system where BitLocker is enabled, when choosing "Install Ubuntu
- alongside Windows Boot Manager", a page is shown instructing us to turn
- off BitLocker. On this page, a green restart button is shown.
+ alongside Windows Boot Manager", a page is shown instructing us to
+ turn off BitLocker. On this page, a green "Restart" button is shown.
  
  If we now go back and pick "Something else", the advanced partitioning
- screen still displays the green restart button, even though clicking on
- it acts like the expected "Install Now" button.
+ screen still displays the green restart button, even though clicking
+ on it acts like the expected "Install Now" button.
  
- I've attached a proposed patch which makes the button look as expected.
+ Whereas a user could think they are just restarting, but actually
+ clicking an "Install Now" button, the present state risks users losing
+ data.
  
- Ubuntu release: 20.04.3 LTS
- Package version: 20.04.15.17
+ [Test Plan]
+ * Acquire a VM or machine with a partition that is BitLockered.
+ * Run thru the Ubiquity installer:
+   * Install Ubuntu
+   * Appropriate keyboard layout and Continue
+   * Accept defaults at "Updates and other software" Install screen,
+     and Continue
+   * At the Installation type screen, ensure that "Install Ubuntu
+     alongside Windows Boot Manager" is selected, and Continue
+   * The "Turn off bitlocker" screen should now be showing. Click the
+     "Back" button
+   * Select "Something else" and Continue
+   * 3 buttons should be visible in the Bottom row.  When the defect is
+     present, the rightmost button is green and says "Restart".  When
+     the defect has been corrected, the rightmost button says "Install
+     now" and is the same color as the other buttons.
+ 
+ [Where problems could occur]
+ * Any change to the installer must be treated with the highest level
+   of care, as this is a place where users with less experience make
+   changes to a system and can lose data if mistakes are made.
+ 
+ * Are there other code flows where the state variables are incorrect?
+   Since the current code depends on the back button to reset the
+   state, is it doing so completely?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1942648

Title:
  restart button remains visible in the advanced partitioner after the
  bitlocker page is shown

Status in ubiquity package in Ubuntu:
  Fix Released
Status in ubiquity source package in Focal:
  In Progress
Status in ubiquity source package in Impish:
  Fix Released

Bug description:
  [Impact]
  On a system where BitLocker is enabled, when choosing "Install Ubuntu
  alongside Windows Boot Manager", a page is shown instructing us to
  turn off BitLocker. On this page, a green "Restart" button is shown.

  If we now go back and pick "Something else", the advanced partitioning
  screen still displays the green restart button, even though clicking
  on it acts like the expected "Install Now" button.

  Whereas a user could think they are just restarting, but actually
  clicking an "Install Now" button, the present state risks users losing
  data.

  [Test Plan]
  * Acquire a VM or machine with a partition that is BitLockered.
  * Run thru the Ubiquity installer:
    * Install Ubuntu
    * Appropriate keyboard layout and Continue
    * Accept defaults at "Updates and other software" Install screen,
      and Continue
    * At the Installation type screen, ensure that "Install Ubuntu
      alongside Windows Boot Manager" is selected, and Continue
    * The "Turn off bitlocker" screen should now be showing. Click the
      "Back" button
    * Select "Something else" and Continue
    * 3 buttons should be visible in the Bottom row.  When the defect is
      present, the rightmost button is green and says "Restart".  When
      the defect has been corrected, the rightmost button says "Install
      now" and is the same color as the other buttons.

  [Where problems could occur]
  * Any change to the installer must be treated with the highest level
    of care, as this is a place where users with less experience make
    changes to a system and can lose data if mistakes are made.

  * Are there other code flows where the state variables are incorrect?
    Since the current code depends on the back button to reset the
    state, is it doing so completely?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions