[Bug 1977982] Re: Please merge keyutils 1.6.1-3 (main) from Debian unstable (main)

[Olivier Gayot]

** Description changed:

  The Ubuntu delta contains two patches:
  
  * d/p/private-priv.patch:
  This patch was applied in Ubuntu to fix a FTBFS issue on nuxwdog. nuxwdog was a C++ project and would include the header file from libkeyutils-dev. Unfortunately, the header file contains variables named "private" - which is a keyword in C++ but not in C.
  The last version of nuxwdog from the archive is in Bionic so I am tempted to drop this patch. The bug report on Debian was closed/not-fixed when nuxwdog was removed from the archive: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923011
- If we drop this, there is a chance, however, that other packages would FTBFS if they build-depends on libkeyutils-dev and use include the C header in C++ code. Here is the list of packages that build-depends on libkeyutils-dev:
-   * bcachefs-tools
-   * ceph
-   * cifs-utils
-   * ecryptfs-utils
-   * gdm3
-   * gssproxy
-   * ima-evm-utils
-   * kafs-client
-   * krb5
-   * kstart
-   * ndctl
-   * nfs-utils
-   * python-keyutils
-   * sssd
-   * stress-ng
+ If we drop this, there is a chance, however, that other packages would FTBFS if they build-depends on libkeyutils-dev and include the C header in C++ code. Here is the list of packages that build-depends on libkeyutils-dev:
+   * bcachefs-tools
+   * ceph
+   * cifs-utils
+   * ecryptfs-utils
+   * gdm3
+   * gssproxy
+   * ima-evm-utils
+   * kafs-client
+   * krb5
+   * kstart
+   * ndctl
+   * nfs-utils
+   * python-keyutils
+   * sssd
+   * stress-ng
  All these packages are in Debian unstable today and are not FTBFS, so I'd assume it's fine to drop the patch.
  
  * d/p/apply-ttl-to-records.patch:
  This patch was applied recently (from upstream) to fix #1962453. I think we need to keep this patch and I'm considering forwarding it to Debian.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to keyutils in Ubuntu.
https://bugs.launchpad.net/bugs/1977982

Title:
  Please merge keyutils 1.6.1-3 (main) from Debian unstable (main)

Status in keyutils package in Ubuntu:
  Confirmed

Bug description:
  The Ubuntu delta contains two patches:

  * d/p/private-priv.patch:
  This patch was applied in Ubuntu to fix a FTBFS issue on nuxwdog. nuxwdog was a C++ project and would include the header file from libkeyutils-dev. Unfortunately, the header file contains variables named "private" - which is a keyword in C++ but not in C.
  The last version of nuxwdog from the archive is in Bionic so I am tempted to drop this patch. The bug report on Debian was closed/not-fixed when nuxwdog was removed from the archive: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923011
  If we drop this, there is a chance, however, that other packages would FTBFS if they build-depends on libkeyutils-dev and include the C header in C++ code. Here is the list of packages that build-depends on libkeyutils-dev:
    * bcachefs-tools
    * ceph
    * cifs-utils
    * ecryptfs-utils
    * gdm3
    * gssproxy
    * ima-evm-utils
    * kafs-client
    * krb5
    * kstart
    * ndctl
    * nfs-utils
    * python-keyutils
    * sssd
    * stress-ng
  All these packages are in Debian unstable today and are not FTBFS, so I'd assume it's fine to drop the patch.

  * d/p/apply-ttl-to-records.patch:
  This patch was applied recently (from upstream) to fix #1962453. I think we need to keep this patch and I'm considering forwarding it to Debian.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/keyutils/+bug/1977982/+subscriptions