[Bug 1951032] Re: AArch64: Backport memcpy improvements

[Michael Hudson-Doyle]

** Description changed:

  [impact]
  glibc 2.32 contained a number of improvements to the memcpy routines for server-grade AArch64 implementations (in particular, graviton2 & graviton3). They should be backported to focal, as the LTS releases are by far the most used on servers.
  
  [test case]
- Compile the test_memcpy.c that is attached to this report:
+ Download the "bench.tar.gz" attachment from this report. It has a README 
+ that explains what to do, but here it is for reference:
  
- $ gcc -g -O3 test_memcpy.c -o test_memcpy64
+ benchmark for testing arm64 memcpy improvements in SRU
  
- "./test_memcpy64 1024" should be run before and after installing the
- libc packages from proposed. On graviton2 systems, this should show a
- substantial improvement. On other arm64 systems (raspberry pis of
- various vintage, thunderx2, xgene, etc etc) at least no significant
- regression should be seen.
+ This is a benchmark that was derived from the memcpy benchmarks in glibc but altered to benchmark the public 'memcpy' symbol and be linked to the
+ installed libc.
+ 
+ To use this there are 5 steps:
+ 
+ 1. build -- just run "make test"
+ 2. run before upgrade -- "make bench-before"
+ 3. upgrade libc6 package -- depends on what is being tested!
+ 4. run again -- "make bench-after"
+ 5. compare -- "make compare"
+ 
+ It produces output like this:
+ 
+    length |   before |    after |    delta
+ ----------|----------|----------|----------
+     32768 |   125995 |   133696 |   -6.11%
+     65536 |   133349 |   140856 |   -5.63%
+    131072 |   139653 |   146419 |   -4.84%
+    262144 |   145441 |   152353 |   -4.75%
+    524288 |   191951 |   199856 |   -4.12%
+   1048576 |   240515 |   256623 |   -6.70%
+ 
+ On graviton2 systems, this should show an improvement of at least
+ several percent. On other arm64 systems (raspberry pis of various
+ vintage, thunderx2, xgene, etc etc) no significant regression should be
+ seen.
  
  [regression potential]
  Rebuilding glibc is always a little risky (toolchain bugs and incompatibilities between the old and new versions can be surprising). But the autopkgtests and some manual general testing can help here.
  
  For this specific change, there is a potential risk that the new memcpy
  implementation could be used on a system where it is not in fact the
  fastest. We should run the test case not only on the systems where it is
  expected to help, but other systems such as the RPi4 and the launchpad
  build farm to ensure performance is not regressed there.

** Attachment added: "bench.tar.gz"
   https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1951032/+attachment/5566380/+files/bench.tar.gz

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to glibc in Ubuntu.
https://bugs.launchpad.net/bugs/1951032

Title:
  AArch64: Backport memcpy improvements

Status in glibc package in Ubuntu:
  Fix Released
Status in glibc source package in Focal:
  Fix Committed

Bug description:
  [impact]
  glibc 2.32 contained a number of improvements to the memcpy routines for server-grade AArch64 implementations (in particular, graviton2 & graviton3). They should be backported to focal, as the LTS releases are by far the most used on servers.

  [test case]
  Download the "bench.tar.gz" attachment from this report. It has a README 
  that explains what to do, but here it is for reference:

  benchmark for testing arm64 memcpy improvements in SRU

  This is a benchmark that was derived from the memcpy benchmarks in glibc but altered to benchmark the public 'memcpy' symbol and be linked to the
  installed libc.

  To use this there are 5 steps:

  1. build -- just run "make test"
  2. run before upgrade -- "make bench-before"
  3. upgrade libc6 package -- depends on what is being tested!
  4. run again -- "make bench-after"
  5. compare -- "make compare"

  It produces output like this:

     length |   before |    after |    delta
  ----------|----------|----------|----------
      32768 |   125995 |   133696 |   -6.11%
      65536 |   133349 |   140856 |   -5.63%
     131072 |   139653 |   146419 |   -4.84%
     262144 |   145441 |   152353 |   -4.75%
     524288 |   191951 |   199856 |   -4.12%
    1048576 |   240515 |   256623 |   -6.70%

  On graviton2 systems, this should show an improvement of at least
  several percent. On other arm64 systems (raspberry pis of various
  vintage, thunderx2, xgene, etc etc) no significant regression should
  be seen.

  [regression potential]
  Rebuilding glibc is always a little risky (toolchain bugs and incompatibilities between the old and new versions can be surprising). But the autopkgtests and some manual general testing can help here.

  For this specific change, there is a potential risk that the new
  memcpy implementation could be used on a system where it is not in
  fact the fastest. We should run the test case not only on the systems
  where it is expected to help, but other systems such as the RPi4 and
  the launchpad build farm to ensure performance is not regressed there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1951032/+subscriptions