[Bug 1953610] Re: cnf-update-db creates unreadable database if wrong umask

Thu Mar 10 19:30:45 UTC 2022

Verification for Impish

root at verify-lp1953610-impish:~# ### Verification
# Install updated command-not-found from -proposed
# https://wiki.ubuntu.com/Testing/EnableProposed
cat <<EOF >/etc/apt/sources.list.d/ubuntu-$(lsb_release -cs)-proposed.list
# Enable Ubuntu proposed archive
deb http://archive.ubuntu.com/ubuntu/ $(lsb_release -cs)-proposed restricted main multiverse universe
EOF
root at verify-lp1953610-impish:~# # Update command-not-found.
apt update
apt install command-not-found
<snip>
Get:17 http://archive.ubuntu.com/ubuntu impish-proposed/universe amd64 c-n-f Metadata [1484 B]
Fetched 543 kB in 2s (268 kB/s)           
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
7 packages can be upgraded. Run 'apt list --upgradable' to see them.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
The following additional packages will be installed:
  python3-commandnotfound
The following packages will be upgraded:
  command-not-found python3-commandnotfound
2 upgraded, 0 newly installed, 0 to remove and 5 not upgraded.
Need to get 15.6 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 command-not-found all 21.10.1 [5100 B]
Get:2 http://archive.ubuntu.com/ubuntu impish-proposed/main amd64 python3-commandnotfound all 21.10.1 [10.5 kB]
Fetched 15.6 kB in 0s (34.3 kB/s)                   
(Reading database ... 32292 files and directories currently installed.)
Preparing to unpack .../command-not-found_21.10.1_all.deb ...
Unpacking command-not-found (21.10.1) over (21.10.0) ...
Preparing to unpack .../python3-commandnotfound_21.10.1_all.deb ...
Unpacking python3-commandnotfound (21.10.1) over (21.10.0) ...
Setting up python3-commandnotfound (21.10.1) ...
Setting up command-not-found (21.10.1) ...
Scanning processes...                                                                                                                                                                    

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.
root at verify-lp1953610-impish:~# # Verify version
dpkg -l | grep command-not-found
ii  command-not-found              21.10.1                            all          Suggest installation of packages in interactive bash sessions
ii  python3-commandnotfound        21.10.1                            all          Python 3 bindings for command-not-found.
root at verify-lp1953610-impish:~# # Force rebuild of DB
rm -rf /var/lib/command-not-found/*
apt update
ls -lah /var/lib/command-not-found/
Hit:1 http://security.ubuntu.com/ubuntu impish-security InRelease
Hit:2 http://archive.ubuntu.com/ubuntu impish InRelease
Hit:3 http://archive.ubuntu.com/ubuntu impish-updates InRelease
Hit:4 http://archive.ubuntu.com/ubuntu impish-backports InRelease
Hit:5 http://archive.ubuntu.com/ubuntu impish-proposed InRelease
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
5 packages can be upgraded. Run 'apt list --upgradable' to see them.
total 3.2M
drwxr-xr-x 1 root root   62 Mar 10 19:21 .
drwxr-xr-x 1 root root  506 Mar 10 19:06 ..
-rw-r--r-- 1 root root 3.2M Mar 10 19:21 commands.db
-rw-r--r-- 1 root root 3.9K Mar 10 19:21 commands.db.metadata
root at verify-lp1953610-impish:~# # Verify success
su - ubuntu
ubuntu at verify-lp1953610-impish:~$ lck
WARNING:root:could not open file '/etc/apt/sources.list.d/ubuntu-impish-proposed.list'

Command 'lck' not found, did you mean:
  command 'lcp' from deb lsh-client (2.1-13)
  command 'lcf' from deb ucf (3.0043)
  command 'zck' from deb zchunk (1.1.9+ds1-1)
  command 'ck' from deb python3-ck (1.9.4-1.1)
  command 'ack' from deb ack (3.4.0-1)
  command 'lc' from deb mono-devel (6.8.0.105+dfsg-3)
  command 'ick' from deb intercal (30:0.30-3)
Try: apt install <deb name>
ubuntu at verify-lp1953610-impish:~$ ack
WARNING:root:could not open file '/etc/apt/sources.list.d/ubuntu-impish-proposed.list'

Command 'ack' not found, but can be installed with:
apt install ack
Please ask your administrator.
ubuntu at verify-lp1953610-impish:~$ exit
logout
root at verify-lp1953610-impish:~# ## END Verification

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to command-not-found in Ubuntu.
https://bugs.launchpad.net/bugs/1953610

Title:
  cnf-update-db creates unreadable database if wrong umask

Status in command-not-found package in Ubuntu:
  Fix Released
Status in command-not-found source package in Bionic:
  Fix Committed
Status in command-not-found source package in Focal:
  Fix Committed
Status in command-not-found source package in Impish:
  Fix Committed
Status in command-not-found source package in Jammy:
  Fix Released

Bug description:
  [Impact]
  If a non-default umask is set for the root user, then the database created by cnf-update-db is not readable by users. This causes exceptions when cnf is invoked.

  This fix ensures databases are created with the correct permissions,
  but it does not automatically reset permissions for broken databases.

  [Test Plan]
  To reproduce the issue, use the annotated steps below. Confirmed working as a reproducer for Bionic, Focal and Impish. Bionic appears to use a -data package instead of building the db on "apt update", however, adding a non-default repo with CNF metadata will also reproduce the issue. Bionic was tested by adding focal-updates to the APT configuration.

  Notes:
  1) The "ubuntu" user below is unprivileged, the result of the "adduser ubuntu" command being run and accepting defaults.
  2) The "lck" and "ack" commands were randomly selected as commands that were unavailable on the default Ubuntu images used by LXD.
  3) Bionic requires the addition of a non-default repo with CNF metadata. The focal-updates repo was used in my testing, any repo meeting the conditions should do.

  ### Reproduction
  # Add repo with CNF metadata if testing Bionic
  # Confirm UMASK
  grep "^UMASK" /etc/login.defs
  # Set /etc/login.defs to umask 027
  sed -i -e 's/^UMASK\t\t022/UMASK\t\t027/' /etc/login.defs
  # Confirm
  grep "^UMASK" /etc/login.defs
  # Log out and back in
  exit

  # Log back in
  # Force rebuild of DB
  rm -rf /var/lib/command-not-found/*
  apt update
  ls -lah /var/lib/command-not-found/
  # Verify failure
  su - ubuntu
  lck
  ack
  exit
  ## END Reproduction

  ### Verification
  # Install updated command-not-found from -proposed
  # https://wiki.ubuntu.com/Testing/EnableProposed
  # Update command-not-found.
  apt upgrade command-not-found
  # Verify version
  dpkg -l | grep command-not-found
  # Force rebuild of DB
  rm -rf /var/lib/command-not-found/*
  apt update
  ls -lah /var/lib/command-not-found/
  # Verify success
  su - ubuntu
  lck
  ack
  exit
  ## END Verification

  The failures expected to be seen when running the "lck" and "ack" commands are similar to:
  ubuntu at lp1953610-focal:~$ ack
  Sorry, command-not-found has crashed! Please file a bug report at:
  https://bugs.launchpad.net/command-not-found/+filebug
  Please include the following information with the report:

  command-not-found version: 0.3
  Python version: 3.8.10 final 0
  Distributor ID: Ubuntu
  Description: Ubuntu 20.04.3 LTS
  Release: 20.04
  Codename: focal
  Exception information:

  unable to open database file
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/CommandNotFound/util.py", line 23, in crash_guard
      callback()
    File "/usr/lib/command-not-found", line 90, in main
      cnf = CommandNotFound.CommandNotFound(options.data_dir)
    File "/usr/lib/python3/dist-packages/CommandNotFound/CommandNotFound.py", line 79, in __init__
      self.db = SqliteDatabase(dbpath)
    File "/usr/lib/python3/dist-packages/CommandNotFound/db/db.py", line 12, in __init__
      self.con = sqlite3.connect(filename)
  sqlite3.OperationalError: unable to open database file

  A successful run should look like:
  ubuntu at lp1953610-focal:~$ lck

  Command 'lck' not found, did you mean:

    command 'ack' from deb ack (3.3.1-1)
    command 'ick' from deb intercal (30:0.30-3)
    command 'lcp' from deb lsh-client (2.1-12build3)
    command 'lc' from deb mono-devel (6.8.0.105+dfsg-2)
    command 'lcf' from deb ucf (3.0038+nmu1)
    command 'ck' from deb python3-ck (1.9.4-1.1)

  Try: apt install <deb name>

  The umask changes have little regression potential, are tested in a
  smoke test, and there is a larger test suite that ensures it does not
  regress other bits (which again, it really shouldn't)

  [Where problems could occur]
  In general, regressions due to this bug would continue showing up as file access errors, either in automated tooling that currently works around the faulty database permissions, or in other packages relying on CNF. 

  Admins could be relying on the incorrect behavior for some reason
  (e.g. security), and some users could have existing automation in
  place to correct the issue manually. We'd expect the fix to have
  little impact on such scenarios, and the patches have been tested for
  these cases.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/command-not-found/+bug/1953610/+subscriptions